Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This is a test, please ignore, I'll close in a sec :) #3892

Closed
wants to merge 4 commits into from

Conversation

ivoanjo
Copy link
Member

@ivoanjo ivoanjo commented Sep 5, 2024

What does this PR do?

Motivation:

Additional Notes:

How to test the change?

Unsure? Have a question? Request a review!

y9v and others added 3 commits September 5, 2024 10:30
This addresses the deprecation warning that `ostruct` will not be
part of standard library since ruby 3.5
@pr-commenter
Copy link

pr-commenter bot commented Sep 5, 2024

Benchmarks

Benchmark execution time: 2024-09-05 09:27:34

Comparing candidate commit 721860d in PR branch ivoanjo/update-appraisals with baseline commit ae50107 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 22 metrics, 3 unstable metrics.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.85%. Comparing base (ae50107) to head (61377d0).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3892      +/-   ##
==========================================
- Coverage   97.85%   97.85%   -0.01%     
==========================================
  Files        1277     1277              
  Lines       76392    76392              
  Branches     3744     3744              
==========================================
- Hits        74757    74756       -1     
- Misses       1635     1636       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ivoanjo
Copy link
Member Author

ivoanjo commented Sep 5, 2024

Mischief managed, closing this PR

@ivoanjo ivoanjo closed this Sep 5, 2024
@ivoanjo ivoanjo deleted the ivoanjo/update-appraisals branch September 5, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants