Improve brittle assertion #3896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TonyCTHsu
force-pushed
the
tonycthsu/improve-assertion
branch
from
5efa37f
to
219449b
Compare
![datadog-datadog-prod-us1[bot]](https://avatars.githubusercontent.com/u/365230?s=60&v=4){kind=small}
TonyCTHsu
force-pushed
the
tonycthsu/improve-assertion
branch
from
219449b
to
233920b
Compare
BenchmarksBenchmark execution time: 2024-09-06 16:25:55 Comparing candidate commit d2bd61a in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 23 metrics, 2 unstable metrics. |
TonyCTHsu
force-pushed
the
tonycthsu/improve-assertion
branch
from
233920b
to
d2bd61a
Compare
TonyCTHsu
added
the
dev/internal
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3896 +/- ##
==========================================
- Coverage 97.86% 97.85% -0.02%
==========================================
Files 1279 1279
Lines 76500 76499 -1
Branches 3745 3745
==========================================
- Hits 74870 74859 -11
- Misses 1630 1640 +10 ☔ View full report in Codecov by Sentry. |
y9v
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
#3890
The assertion such as (
expect(out).to eq('ACTUAL:true') is brittle.Our test should NOT be broken because of a warning that
ostructandfiddleare going to standard lib in 3.5 (should not effect 3.3).Such failure pattern can apply to other gems as well when emitting additional output.