Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add telemetry logs for instrumentations #3899

Merged
merged 3 commits into from
Sep 10, 2024

Conversation

TonyCTHsu
Copy link
Contributor

@TonyCTHsu TonyCTHsu commented Sep 10, 2024

What does this PR do?

Send Telemetry logs among instrumentation.

@github-actions github-actions bot added integrations Involves tracing integrations tracing labels Sep 10, 2024
@codecov-commenter
Copy link

codecov-commenter commented Sep 10, 2024

Codecov Report

Attention: Patch coverage is 72.85714% with 19 lines in your changes missing coverage. Please review.

Project coverage is 97.84%. Comparing base (d5017d4) to head (5940d5f).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
lib/datadog/tracing/contrib/grape/endpoint.rb 16.66% 5 Missing ⚠️
...ib/datadog/tracing/contrib/http/instrumentation.rb 66.66% 4 Missing ⚠️
lib/datadog/tracing/contrib/opensearch/patcher.rb 62.50% 3 Missing ⚠️
...b/action_pack/action_controller/instrumentation.rb 33.33% 2 Missing ⚠️
...b/datadog/tracing/contrib/elasticsearch/patcher.rb 33.33% 2 Missing ⚠️
...adog/tracing/contrib/httpclient/instrumentation.rb 33.33% 2 Missing ⚠️
.../datadog/tracing/contrib/httprb/instrumentation.rb 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3899      +/-   ##
==========================================
- Coverage   97.87%   97.84%   -0.04%     
==========================================
  Files        1279     1279              
  Lines       76502    76529      +27     
  Branches     3747     3752       +5     
==========================================
+ Hits        74879    74880       +1     
- Misses       1623     1649      +26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TonyCTHsu TonyCTHsu force-pushed the tonycthsu/telemetry_log_instrumentation branch from bc215a1 to 42b74ed Compare September 10, 2024 09:13
@TonyCTHsu TonyCTHsu changed the base branch from master to tonycthsu/remove-obsolete-only-once September 10, 2024 09:13
@TonyCTHsu TonyCTHsu added dev/refactor Involves refactoring existing components dev/internal Other internal work that does not need to be included in the changelog labels Sep 10, 2024
Base automatically changed from tonycthsu/remove-obsolete-only-once to master September 10, 2024 10:47
@TonyCTHsu TonyCTHsu marked this pull request as ready for review September 10, 2024 14:13
@TonyCTHsu TonyCTHsu requested a review from a team as a code owner September 10, 2024 14:13
@TonyCTHsu TonyCTHsu force-pushed the tonycthsu/telemetry_log_instrumentation branch from 3cc6963 to c1f302b Compare September 10, 2024 14:55
@pr-commenter
Copy link

pr-commenter bot commented Sep 10, 2024

Benchmarks

Benchmark execution time: 2024-09-10 15:40:05

Comparing candidate commit 5940d5f in PR branch tonycthsu/telemetry_log_instrumentation with baseline commit d5017d4 in branch master.

Found 1 performance improvements and 0 performance regressions! Performance is the same for 22 metrics, 2 unstable metrics.

scenario:profiler - profiler gc

  • 🟩 throughput [+18482.964op/s; +19175.710op/s] or [+5.333%; +5.533%]

@TonyCTHsu TonyCTHsu merged commit bc84181 into master Sep 10, 2024
191 checks passed
@TonyCTHsu TonyCTHsu deleted the tonycthsu/telemetry_log_instrumentation branch September 10, 2024 17:53
@TonyCTHsu TonyCTHsu added this to the 2.4.0 milestone Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev/internal Other internal work that does not need to be included in the changelog dev/refactor Involves refactoring existing components integrations Involves tracing integrations tracing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants