Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock dependencies workflow #3926

Merged
merged 5 commits into from
Sep 19, 2024
Merged

Conversation

TonyCTHsu
Copy link
Contributor

@TonyCTHsu TonyCTHsu commented Sep 18, 2024

Why

The existing automation is suffering with

  • Takes too long (~ 30 mins +)
  • commit landed on other pull request
  • Depends heavily on docker and appraisal

What does this PR do?

  • Implement lock task for each runtime for parellelism
  • Improve the speed automation (~ 1 min for CRuby and ~4 min for JRuby)
  • Improve the accuracy for diff comparison (between PR base and branch)

Using stripe-min as an example to integrate into our development workflow

here is an example how it look: https://github.com/DataDog/dd-trace-rb/actions/runs/10937852122

@pr-commenter
Copy link

pr-commenter bot commented Sep 18, 2024

Benchmarks

Benchmark execution time: 2024-09-19 10:16:54

Comparing candidate commit 93438f4 in PR branch tonycthsu/automate-update-gemfiles with baseline commit f6ec8b7 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 23 metrics, 2 unstable metrics.

@TonyCTHsu TonyCTHsu force-pushed the tonycthsu/automate-update-gemfiles branch 12 times, most recently from e730358 to 8419f44 Compare September 18, 2024 23:03
@codecov-commenter
Copy link

codecov-commenter commented Sep 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.78%. Comparing base (f6ec8b7) to head (93438f4).
Report is 41 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3926      +/-   ##
==========================================
- Coverage   97.78%   97.78%   -0.01%     
==========================================
  Files        1291     1291              
  Lines       77149    77151       +2     
  Branches     3810     3815       +5     
==========================================
+ Hits        75440    75441       +1     
- Misses       1709     1710       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TonyCTHsu TonyCTHsu force-pushed the tonycthsu/automate-update-gemfiles branch 3 times, most recently from 0c72d23 to a191ad3 Compare September 19, 2024 07:08
@TonyCTHsu TonyCTHsu force-pushed the tonycthsu/automate-update-gemfiles branch 2 times, most recently from 5c7a8a6 to de4f9c9 Compare September 19, 2024 09:03
@TonyCTHsu TonyCTHsu force-pushed the tonycthsu/automate-update-gemfiles branch from 6b60e93 to 34416f3 Compare September 19, 2024 09:13
@github-actions github-actions bot added integrations Involves tracing integrations tracing labels Sep 19, 2024
@TonyCTHsu TonyCTHsu changed the title Manual lock dependencies Lock dependencies workflow Sep 19, 2024
@TonyCTHsu TonyCTHsu marked this pull request as ready for review September 19, 2024 09:47
@TonyCTHsu TonyCTHsu requested a review from a team as a code owner September 19, 2024 09:47
@TonyCTHsu TonyCTHsu requested a review from a team as a code owner September 19, 2024 09:47
@TonyCTHsu TonyCTHsu added dev/tooling Involves tools (e.g. Rubocop, CodeCov) dev/testing Involves testing processes (e.g. RSpec) dev/github Github repository maintenance and automation labels Sep 19, 2024
@TonyCTHsu TonyCTHsu merged commit 9b1d33b into master Sep 19, 2024
207 checks passed
@TonyCTHsu TonyCTHsu deleted the tonycthsu/automate-update-gemfiles branch September 19, 2024 18:39
@github-actions github-actions bot added this to the 2.4.0 milestone Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev/github Github repository maintenance and automation dev/testing Involves testing processes (e.g. RSpec) dev/tooling Involves tools (e.g. Rubocop, CodeCov) integrations Involves tracing integrations tracing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants