Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove builder dependency #3957

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Remove builder dependency #3957

wants to merge 2 commits into from

Conversation

TonyCTHsu
Copy link
Contributor

@TonyCTHsu TonyCTHsu commented Sep 26, 2024

What does this PR do?

The dependency in Gemfile is obsolete.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.87%. Comparing base (fa61ea2) to head (4d024d3).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3957      +/-   ##
==========================================
+ Coverage   97.85%   97.87%   +0.01%     
==========================================
  Files        1305     1305              
  Lines       78235    78235              
  Branches     3893     3893              
==========================================
+ Hits        76558    76571      +13     
+ Misses       1677     1664      -13     
Flag Coverage Δ
97.87% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pr-commenter
Copy link

pr-commenter bot commented Sep 26, 2024

Benchmarks

Benchmark execution time: 2024-09-26 13:12:48

Comparing candidate commit 4d024d3 in PR branch tonycthsu/remove-builder with baseline commit fa61ea2 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 23 metrics, 2 unstable metrics.

@TonyCTHsu TonyCTHsu changed the title [WIP] Remove obsolete deps Remove builder dependency Sep 26, 2024
@TonyCTHsu TonyCTHsu added the dev/internal Other internal work that does not need to be included in the changelog label Sep 26, 2024
@TonyCTHsu TonyCTHsu marked this pull request as ready for review September 26, 2024 15:29
@TonyCTHsu TonyCTHsu requested a review from a team as a code owner September 26, 2024 15:29
Copy link

@Strech Strech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deletion master 👍🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev/internal Other internal work that does not need to be included in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants