[NO-TICKET] Bump debase-ruby_core_source dependency to 3.3.5 #3971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**What does this PR do?** This PR bumps our dependency on debase-ruby_core_source to version 3.3.5. This version includes the headers for the Ruby 3.3.5 as well as 3.4.0-preview1; up until now we were supporting those Ruby versions using the 3.3.0 headers. **Motivation:** Use up-to-date headers for profiling on Ruby 3.3.5 and 3.4.0-preview1. **Additional Notes:** I've updated the appraisal gemfiles as well. **How to test the change?** Validate that CI is green.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3971 +/- ##
==========================================
- Coverage 97.87% 97.86% -0.01%
==========================================
Files 1313 1313
Lines 78352 78352
Branches 3886 3886
==========================================
- Hits 76684 76680 -4
- Misses 1668 1672 +4 ☔ View full report in Codecov by Sentry. |
BenchmarksBenchmark execution time: 2024-10-03 13:58:20 Comparing candidate commit 8c5c3b4 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 23 metrics, 2 unstable metrics. |
p-datadog
approved these changes
Oct 3, 2024
ivoanjo
changed the title
|
Superceded by #3988, closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR bumps our dependency on debase-ruby_core_source to version 3.3.5. This version includes the headers for the Ruby 3.3.5 as well as 3.4.0-preview1; up until now we were supporting those Ruby versions using the 3.3.0 headers.
Motivation:
Use up-to-date headers for profiling on Ruby 3.3.5 and 3.4.0-preview1.
Additional Notes:
I've updated the appraisal gemfiles as well.
How to test the change?
Validate that CI is green.