-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Telemetry: Add environment variable to disable logs #4153
Conversation
7bbd84e
to
0958318
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4153 +/- ##
=======================================
Coverage 97.75% 97.76%
=======================================
Files 1357 1357
Lines 81890 81920 +30
Branches 4164 4164
=======================================
+ Hits 80054 80089 +35
+ Misses 1836 1831 -5 ☔ View full report in Codecov by Sentry. |
Interesting -- this was surprising to me. Is the intent here to reduce the amount of data sent? |
@ivoanjo, yes. It's a cautionary setting in case log generations suddenly starts spamming logs due to unforeseen changes. This toggle was supposed to be here from the start, when we first introduced telemetry logs, in order to have a safer rollout. |
Datadog ReportBranch report: ✅ 0 Failed, 22044 Passed, 1458 Skipped, 5m 34.79s Total Time |
Adds the
DD_TELEMETRY_LOG_COLLECTION_ENABLED
environment variable to disable telemetry log collection, which is enabled by default.Also, this PR disables telemetry logs in forked processes, to align telemetry logs with all other telemetry signals, which do not send on forks.