-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch AppSec rack blocking to throw #4281
Conversation
b6e6b26
to
e57f4e3
Compare
Datadog ReportBranch report: ✅ 0 Failed, 22196 Passed, 1476 Skipped, 5m 9.11s Total Time |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4281 +/- ##
==========================================
- Coverage 97.72% 97.71% -0.01%
==========================================
Files 1354 1354
Lines 82416 82411 -5
Branches 4220 4213 -7
==========================================
- Hits 80537 80527 -10
- Misses 1879 1884 +5 ☔ View full report in Codecov by Sentry. |
BenchmarksBenchmark execution time: 2025-01-14 13:12:10 Comparing candidate commit 629e7b5 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 31 metrics, 2 unstable metrics. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be cool to understand the end goal of adjustments because there is a common issue when step-by-step adjustments might lead to sub-par result without knowing what kind of design will be at the end.
f93c068
to
b076bfe
Compare
b076bfe
to
dbef0c8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We discuss this step and I don't have any concerns
We want to have a unified way of blocking in AppSec.
dbef0c8
to
629e7b5
Compare
What does this PR do?
We want to have a unified way of blocking in AppSec and separate
catch
return arguments fromGateway#watch
return arguments.Motivation:
Reducing code complexity.
Change log entry
None.
Additional Notes:
None.
How to test the change?
CI and manual testing with app generator.