Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch AppSec rack blocking to throw #4281

Merged
merged 6 commits into from
Jan 14, 2025
Merged

Conversation

y9v
Copy link
Member

@y9v y9v commented Jan 13, 2025

What does this PR do?
We want to have a unified way of blocking in AppSec and separate catch return arguments from Gateway#watch return arguments.

Motivation:
Reducing code complexity.

Change log entry
None.

Additional Notes:
None.

How to test the change?
CI and manual testing with app generator.

@y9v y9v self-assigned this Jan 13, 2025
@y9v y9v requested a review from a team as a code owner January 13, 2025 11:18
@github-actions github-actions bot added integrations Involves tracing integrations appsec Application Security monitoring product labels Jan 13, 2025
@y9v y9v force-pushed the appsec-use-throw-for-rack-blocking branch from b6e6b26 to e57f4e3 Compare January 13, 2025 11:19
@datadog-datadog-prod-us1
Copy link
Contributor

datadog-datadog-prod-us1 bot commented Jan 13, 2025

Datadog Report

Branch report: appsec-use-throw-for-rack-blocking
Commit report: 629e7b5
Test service: dd-trace-rb

✅ 0 Failed, 22196 Passed, 1476 Skipped, 5m 9.11s Total Time

@codecov-commenter
Copy link

codecov-commenter commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.71%. Comparing base (1d24f5d) to head (629e7b5).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4281      +/-   ##
==========================================
- Coverage   97.72%   97.71%   -0.01%     
==========================================
  Files        1354     1354              
  Lines       82416    82411       -5     
  Branches     4220     4213       -7     
==========================================
- Hits        80537    80527      -10     
- Misses       1879     1884       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pr-commenter
Copy link

pr-commenter bot commented Jan 13, 2025

Benchmarks

Benchmark execution time: 2025-01-14 13:12:10

Comparing candidate commit 629e7b5 in PR branch appsec-use-throw-for-rack-blocking with baseline commit 1d24f5d in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 31 metrics, 2 unstable metrics.

Copy link
Member

@Strech Strech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be cool to understand the end goal of adjustments because there is a common issue when step-by-step adjustments might lead to sub-par result without knowing what kind of design will be at the end.

@y9v y9v force-pushed the appsec-use-throw-for-rack-blocking branch from f93c068 to b076bfe Compare January 13, 2025 13:50
@y9v y9v force-pushed the appsec-use-throw-for-rack-blocking branch from b076bfe to dbef0c8 Compare January 13, 2025 13:53
Copy link
Member

@Strech Strech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We discuss this step and I don't have any concerns

@y9v y9v force-pushed the appsec-use-throw-for-rack-blocking branch from dbef0c8 to 629e7b5 Compare January 14, 2025 12:48
@y9v y9v merged commit 5235204 into master Jan 14, 2025
378 checks passed
@y9v y9v deleted the appsec-use-throw-for-rack-blocking branch January 14, 2025 13:39
@github-actions github-actions bot added this to the 2.9.0 milestone Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
appsec Application Security monitoring product integrations Involves tracing integrations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants