Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hyper certification requirements #59

Merged
merged 11 commits into from
Apr 25, 2022
Merged

Conversation

r1viollet
Copy link
Collaborator

What does this PR do?

Adapt to API changes.
This does not compile as it would require a new publication of libddprof.

libddprof matching PR is here :
DataDog/libddprof#47

Motivation

Today we can not publish a new version of libddprof

This would require a new publication of libddprof
@r1viollet r1viollet marked this pull request as draft April 11, 2022 11:11
@r1viollet
Copy link
Collaborator Author

Pending a new release from libddprof

sanchda
sanchda previously approved these changes Apr 11, 2022
Copy link
Collaborator

@sanchda sanchda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll read the libddprof PR to familiarize myself with the new interface, but as far as ddprof is concerned this looks good to me. Thanks!

src/exporter/ddprof_exporter.cc Show resolved Hide resolved
nsavoire
nsavoire previously approved these changes Apr 12, 2022
Copy link
Collaborator

@nsavoire nsavoire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes !

@r1viollet r1viollet dismissed stale reviews from nsavoire and sanchda via 571c06d April 14, 2022 16:06
@r1viollet r1viollet marked this pull request as ready for review April 25, 2022 08:52
src/exporter/ddprof_exporter.cc Outdated Show resolved Hide resolved
src/exporter/ddprof_exporter.cc Outdated Show resolved Hide resolved
src/exporter/ddprof_exporter.cc Outdated Show resolved Hide resolved
src/exporter/ddprof_exporter.cc Outdated Show resolved Hide resolved
Fix leak: Ownership of tags are not given to the exporter. They should be freed.
Simplify conversions to CharSlice
Avoid adding tags when elements are not specified
Copy link
Collaborator

@nsavoire nsavoire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@r1viollet r1viollet merged commit 7766ee0 into main Apr 25, 2022
@r1viollet r1viollet deleted the r1viollet/fix_hyper_certs branch June 30, 2022 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants