-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix hyper certification requirements #59
Conversation
This would require a new publication of libddprof
Pending a new release from libddprof |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll read the libddprof PR to familiarize myself with the new interface, but as far as ddprof is concerned this looks good to me. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fixes !
Adapt to recent API changes on tags.
Fix leak: Ownership of tags are not given to the exporter. They should be freed.
Simplify conversions to CharSlice
Avoid adding tags when elements are not specified
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
What does this PR do?
Adapt to API changes.
This does not compile as it would require a new publication of libddprof.
libddprof matching PR is here :
DataDog/libddprof#47
Motivation
Today we can not publish a new version of libddprof