[OpenTelemetry Collector] Update example with new configuration #13787
Conversation
| - example:tag | ||
| host_metadata: | ||
| tags: | ||
| - example:tag | ||
|
|
||
| api: | ||
| key: aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa |
There was a problem hiding this comment.
Not that you change that and it is not a big deal at all but IMHO aaaaa... looks bit strange. Arguably xxxxxx... or XXXX... more traditional substitution. And I think [xxxxx...] or <xxx...> have a better implied intentions.
There was a problem hiding this comment.
I've seen aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa used for API key at Datadog more than once, and I personally prefer it to xxxx or XXXX.
"a" is the first letter of the alphabet and it sounds like someone saying "aaaaaaah", like "aaaaah we're missing the API key".
But you can't pronounce "XXXXX" :)
I don't particularly agree that "XXXX" has better implied intentions.
There was a problem hiding this comment.
👍 that's a good point. I think the right choice here is to put as an example:
api:
key: ${DD_API_KEY}
and pass the API key as an environment variable, which is the recommended setup for sensitive fields.
This needs to change in a few places though and I think I want to wait a bit until we have made a change on environment variable resolution, but I will make a note, thanks!
There was a problem hiding this comment.
I've seen aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa used for API key at Datadog more than once, and I personally prefer it to xxxx or XXXX.
"a" is the first letter of the alphabet and it sounds like someone saying "aaaaaaah", like "aaaaah we're missing the API key".
But you can't pronounce "XXXXX" :)
I don't particularly agree that "XXXX" has better implied intentions.
That teaches me that what I am very biased even about most obvious (for me) thing :)
|
@alai97 any reason why the build preview job is not running? |
What does this PR do?
Change
tagssetting to reflect the newhost_metadatasection from open-telemetry/opentelemetry-collector-contrib/pull/9100, available from v0.49.0Motivation
As documented in open-telemetry/opentelemetry-collector-contrib/issues/9099, the
tagssetting is deprecated and will eventually be removed in favor of thehost_metadata::tagssection.Preview
https://docs-staging.datadoghq.com/<BRANCH_NAME>/
Additional Notes
Reviewer checklist