-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOCS-6807] Historical Metrics Ingestion #20809
Conversation
Adding code examples for Late Metrics Submission via DogStatsD.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
initial round of review; please make the updates and let me know when it's ready for round 2 review
...s/metrics/custom_metrics/historical_metrics/diagram_historical-metrics-ingestion_billing.png
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To me, instead of having the previous state vs current state (with HMI) enabled being linearly presented top down, i feel like the message would be clearer if you presented it side by side (no HMI enabled vs HMI enabled - left right respectively)
The message of "metric point delayed by 1h & 1 min or 3hrs" is in red and distracts the user with the question of why is my point delayed? is it dd's fault? My suggested edit is to change "metric point delayed by 1hr&1min" to "historical data's timestamp from 1h&1min ago" or something along those lines
Another comment I have is that the DD icon appears after the purple box of metrics intake...which from a customer's perspective is DD. Could we have a larger boundary to encapsulate what's actually on the DD side vs being submitted by the customer ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mitheysh-asokan for some reason this comment doesn't show up on the files we reviewed. Wanted to make sure you saw this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did speak to our designer about this, but it sounds like a side-by side for public docs might not be an optimal viewing experience - due to some length limitations. He advises on making the section seperations to be more prominent instead of making them side-by-side.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested Title: "Ingesting historical metrics data can take longer depending on the timestamp"
Comments:
- Again metrics intake is a part of DD -- right now the image looks like we do edge processing before it reaches the rest of DD which isn't the point of the image.
- For metric A's points that have timestamps from 3 months ago or 15 months ago, it's unnecessary IMO to include the hourly timestamp -- just adds visual clutter
- Same comment as above by the term "delayed"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
static/images/metrics/custom_metrics/historical_metrics/enable_historical_metrics.png
Outdated
Show resolved
Hide resolved
Co-authored-by: Kathy L. <kathy.lin@datadoghq.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it'd be worthwhile for the 3 of us to hop on a quick 15 minute sync and whiteboard what changes need to be made to the diagrams before we can publish these public docs. The current pictures are not illustrating the functionality in an effective way.
| +30 days | +14 hours latency | | ||
|
||
|
||
{{< img src="metrics/custom_metrics/historical_metrics/diagram_historical-metrics-ingestion_3_240105.png" alt="Diagram showing how Historical Metrics can take longer to ingest depending on the metric timestamp">}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Highlighting the historical data value's timestamp in pinkish red makes users nervous that there is something incorrect about their submission. Let's change this to black
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolution from mtg - remove the diagram, the table provides sufficient information
Co-authored-by: Kathy L. <kathy.lin@datadoghq.com>
What does this PR do? What is the motivation?
Creates Documentation for Historical Metrics Ingestion Preview
Merge instructions
Additional notes