Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CIVIS] Fix outdated documentation #23060

Merged
merged 5 commits into from
May 9, 2024
Merged

Conversation

TovRudyy
Copy link
Contributor

@TovRudyy TovRudyy commented May 8, 2024

What does this PR do? What is the motivation?

Fixing outdated documentation regarding the concept of "wall time" of Test Visibility.

The wall time was deprecated in a past PR:

However, a posterior PR overwrote the changes and introduced it again by mistake:

We have just realised about this today.

Merge instructions

  • Please merge after reviewing

Additional notes

@TovRudyy TovRudyy requested review from a team as code owners May 8, 2024 13:47
@TovRudyy TovRudyy requested a review from tonyredondo May 8, 2024 13:47
Copy link
Contributor

@ManuelPalenzuelaDD ManuelPalenzuelaDD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

Copy link
Contributor

@buraizu buraizu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, suggesting some minor edits.

content/en/tests/troubleshooting/_index.md Outdated Show resolved Hide resolved
content/en/tests/troubleshooting/_index.md Outdated Show resolved Hide resolved
@TovRudyy TovRudyy requested a review from buraizu May 9, 2024 12:05
@buraizu buraizu merged commit 51b9f55 into master May 9, 2024
13 of 14 checks passed
@buraizu buraizu deleted the olek.rudyy/fix-test-walltime branch May 9, 2024 16:38
@rodrimendoza rodrimendoza mentioned this pull request May 13, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants