Added kafka context propagation note #8194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added configuration specific to Kafka from here: DataDog/dd-trace-java#1448
| @@ -87,6 +87,8 @@ Don't see your desired web frameworks? Datadog is continually adding additional | |||
| | Rabbit AMQP | 2.7+ | Fully Supported | `amqp`, `rabbitmq` | | |||
| | Spring WebClient | 5.0+ | Fully Supported | `spring-webflux`, `spring-webflux-client` | | |||
|
|
|||
| **Note**: Our Kafka Integration works with version `0.11+` as this version of Kafka supports the Header API, where we inject/extract trace context. If you a running a mixed version environment, the Kafka broker will sometimes report the newer version of Kafka. This can cause an issue as the tracer will try to inject headers when it’s not supported by the local producer, or older consumers will be unable to consume the message because of the presence of headers. To prevent this issue if you are running a mixed version Kafka environment with versions older than 0.11, context propagation can be disabled with the following environment variable: `DD_KAFKA_CLIENT_PROPAGATION_ENABLED=false`. | |||
There was a problem hiding this comment.
"sometimes incorrectly report the newer version of Kafka"
richardstartin
approved these changes
Aug 5, 2020
added 2 commits
August 5, 2020 10:43
tylerbenson
approved these changes
Aug 5, 2020
ruthnaebeck
suggested changes
Aug 5, 2020
Co-authored-by: ruthnaebeck <19349244+ruthnaebeck@users.noreply.github.com>
apigirl
approved these changes
Aug 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added configuration specific to Kafka from here: DataDog/dd-trace-java#1448
What does this PR do?
Motivation
Preview link
https://docs-staging.datadoghq.com/andrewsouthard1-patch-1/tracing/compatibility_requirements/java/#networking-framework-compatibility
Check preview base path using the URL in details in
previewstatus check.Additional Notes