Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for logs pipelines CRUD methods #252

Merged
merged 6 commits into from
Jan 25, 2021

Conversation

hi-artem
Copy link
Contributor

@hi-artem hi-artem commented Jan 19, 2021

What does this PR do?

Added support for some endpoint available in the Logs Pipeline API (all CRUD methods).

There is no existing issue, but our project datadog_backup is using the library, and one of the next features we plan to add is logs-pipeline backup/restore. Thus the need to implement the following PR. Some other projects can also find it useful.

Description of the Change

Similar to other resources, like Dashboard and Monitors, the CRUD methods are located in lib/dogapi/v1/logs_pipeline.rb, and respective tests in spec/integration/logs_pipeline_spec.rb. The service was added tolib/dogapi/facade.rb to make CRUD methods accessible to the library consumers.

Review checklist (to be filled by reviewers)

  • Feature or bug fix MUST have appropriate tests (unit, integration, etc...)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have one changelog/ label attached. If applicable it should have the backward-incompatible label attached.
  • PR should not have do-not-merge/ label attached.
  • If Applicable, issue must have kind/ and severity/ labels attached at least.

@hi-artem hi-artem requested a review from a team as a code owner January 19, 2021 01:06
@hi-artem
Copy link
Contributor Author

I think the pipeline error is due to this - might be wrong though.

@hi-artem
Copy link
Contributor Author

Updated: yeah, the 1.9 pipeline was failing due to one of the dependency (crack) of webmock, added rexml to its gemfile. I assume rexml is incompatible with 1.9. Anyway, I pinned crack to 0.4.4 and it passed the build.
Let me know if you have different approach to this issue.

zippolyte
zippolyte previously approved these changes Jan 25, 2021
lib/dogapi/v1/logs_pipeline.rb Outdated Show resolved Hide resolved
@zippolyte zippolyte merged commit 52808a8 into DataDog:master Jan 25, 2021
@zippolyte zippolyte added the changelog/Added Added features results into a minor version bump label Jan 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/Added Added features results into a minor version bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants