Namespace dogstastd #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yannmh
approved these changes
Sep 20, 2016
|
|
||
| ### Changes | ||
| * [OTHER] Namespace the statsd Class under the Datadog module. | ||
|
|
There was a problem hiding this comment.
I believe we should make a highlight ➕ of that . [OTHER] sounds too much of a small change.
| @@ -1,14 +1,14 @@ | |||
| require 'helper' | |||
| require 'timecop' | |||
|
|
|||
| describe Statsd do | |||
| class Statsd | |||
| describe Datadog::Statsd do | |||
There was a problem hiding this comment.
Do we want to rename this one too? https://github.com/DataDog/dogstatsd-ruby/blob/49dd6b293a2774620a791c55fdd2f13f79186d4a/spec/statsd_spec.rb#L552
Otherwise you can't load it with any other type of statsd.
rack ~> 1.6 for Ruby < 2.2 compatibility json ~> 1.8 for Ruby 1.9.3 compatibility
degemer
force-pushed
the
quentin/namespace-dogstatsd
branch
from
49dd6b2
to
c47c983
Compare
|
Thanks for the review @yannmh ! Addressed both of your comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebase of #21.