Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Namespace the Statsd class on the datadog module. #21

Closed
wants to merge 1 commit into from

Conversation

djpate
Copy link

@djpate djpate commented Sep 3, 2015

Otherwise you can't load it with any other type of statsd.

Otherwise you can't load it with any other type of statsd.
@remh
Copy link
Contributor

remh commented Sep 4, 2015

Thanks a lot @djpate we'll review this shortly!

@remh remh added this to the 2.0.0 milestone Sep 4, 2015
@grosser
Copy link
Contributor

grosser commented Nov 10, 2015

Is this ever going to happen ... can you just merge and declare 2.0 ?

@Rshomali
Copy link

Rshomali commented Dec 2, 2015

I really need this to use Datadog for my project. Any estimate when this will be merged?

@grosser
Copy link
Contributor

grosser commented Dec 2, 2015

never ;)

On Wed, Dec 2, 2015 at 9:43 AM, Rami Shomali notifications@github.com
wrote:

I really need this to use Datadog for my project. Any estimate when this
will be merged?


Reply to this email directly or view it on GitHub
#21 (comment)
.

@gphat
Copy link

gphat commented Jan 4, 2016

Ping! This would be a good thing!

@irabinovitch
Copy link

@remh anything pending before we can merge?

EDIT: Actually looks like a rebase at minimum is needed.

@weppos
Copy link
Contributor

weppos commented Apr 13, 2016

I agree that this should be into a separate namespace. It would really nice to have this change merged and released.

@degemer degemer mentioned this pull request Sep 20, 2016
@degemer
Copy link
Member

degemer commented Sep 22, 2016

Thank you all for your patience, dogstatsd-ruby 2.0.0 is out with this change! (PR was rebased in #32 and merged)

Changelog: https://github.com/DataDog/dogstatsd-ruby/blob/master/CHANGELOG.md#200-20160922

@degemer degemer closed this Sep 22, 2016
@djpate
Copy link
Author

djpate commented Sep 22, 2016

yay!

pudiva pushed a commit to pudiva/dogstatsd-ruby that referenced this pull request Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants