Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CONTINT-4406] add helm option to filter kubernetes events #1517

Conversation

ewoodthomas
Copy link
Contributor

@ewoodthomas ewoodthomas commented Sep 3, 2024

What this PR does / why we need it:

#27960 allows users to filter out events. This PR adds the helm option datadog.kubernetesEvents.filteringEnabled to easily allow users to enable event filtering.

Which issue this PR fixes

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Chart Version bumped
  • Documentation has been updated with helm-docs (run: .github/helm-docs.sh)
  • CHANGELOG.md has been updated
  • Variables are documented in the README.md
  • For Datadog Operator chart or value changes update the test baselines (run: make update-test-baselines)

@ewoodthomas ewoodthomas requested a review from a team as a code owner September 3, 2024 19:58
@github-actions github-actions bot added the chart/datadog This issue or pull request is related to the datadog chart label Sep 3, 2024
Copy link
Member

@jennchenn jennchenn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a few comments / nits!

charts/datadog/templates/_kubernetes_apiserver_config.yaml Outdated Show resolved Hide resolved
charts/datadog/templates/_kubernetes_apiserver_config.yaml Outdated Show resolved Hide resolved
@@ -1,5 +1,9 @@
# Datadog changelog

## 3.70.8
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a heads up: since we need to wait for 7.57.0, this will probably need to change :(

charts/datadog/ci/cluster-agent-values.yaml Show resolved Hide resolved
charts/datadog/templates/_kubernetes_apiserver_config.yaml Outdated Show resolved Hide resolved
Copy link
Member

@jennchenn jennchenn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me once the version is bumped (pending 7.57.0 release)!

@ewoodthomas
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Sep 24, 2024

🚂 MergeQueue: pull request added to the queue

The median merge time in main is 38m.

Use /merge -c to cancel this operation!

@dd-mergequeue dd-mergequeue bot merged commit 0010864 into main Sep 24, 2024
18 checks passed
@dd-mergequeue dd-mergequeue bot deleted the ewoodthomas/CONTINT-4406_add_helm_option_to_filter_kubernetes_events branch September 24, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chart/datadog This issue or pull request is related to the datadog chart mergequeue-status: done
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants