-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CONTINT-4406] add helm option to filter kubernetes events #1517
[CONTINT-4406] add helm option to filter kubernetes events #1517
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left a few comments / nits!
charts/datadog/CHANGELOG.md
Outdated
@@ -1,5 +1,9 @@ | |||
# Datadog changelog | |||
|
|||
## 3.70.8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a heads up: since we need to wait for 7.57.0
, this will probably need to change :(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me once the version is bumped (pending 7.57.0
release)!
/merge |
🚂 MergeQueue: pull request added to the queue The median merge time in Use |
What this PR does / why we need it:
#27960 allows users to filter out events. This PR adds the helm option
datadog.kubernetesEvents.filteringEnabled
to easily allow users to enable event filtering.Which issue this PR fixes
Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
.github/helm-docs.sh
)CHANGELOG.md
has been updatedREADME.md
make update-test-baselines
)