Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the statsd config example #12756

Merged
merged 1 commit into from
Aug 17, 2022
Merged

Conversation

FlorentClarret
Copy link
Member

@FlorentClarret FlorentClarret commented Aug 16, 2022

What does this PR do?

Update the statsd config example so the comments are not on the same line as the properties.

Motivation

Support case. Running airflow using this config:

Traceback (most recent call last):
  File "/usr/local/bin/airflow", line 25, in <module>
    from airflow.configuration import conf
  File "/usr/local/lib/python3.8/site-packages/airflow/__init__.py", line 31, in <module>
    from airflow.utils.log.logging_mixin import LoggingMixin
  File "/usr/local/lib/python3.8/site-packages/airflow/utils/__init__.py", line 24, in <module>
    from .decorators import apply_defaults as _apply_defaults
  File "/usr/local/lib/python3.8/site-packages/airflow/utils/decorators.py", line 36, in <module>
    from airflow import settings
  File "/usr/local/lib/python3.8/site-packages/airflow/settings.py", line 121, in <module>
    port=conf.getint('scheduler', 'statsd_port'),
  File "/usr/local/lib/python3.8/site-packages/airflow/configuration.py", line 418, in getint
    return int(self.get(section, key, **kwargs))
ValueError: invalid literal for int() with base 10: '8125       # DogStatsD port configured in the Datadog Agent'

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@github-actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

hithwen
hithwen previously approved these changes Aug 16, 2022
@FlorentClarret
Copy link
Member Author

Customer also confirmed this was their problem. Merging

@FlorentClarret FlorentClarret merged commit 3780660 into master Aug 17, 2022
@FlorentClarret FlorentClarret deleted the florentclarret/airflow-doc branch August 17, 2022 06:43
steveny91 pushed a commit that referenced this pull request Aug 18, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants