Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AGENT-9736] Added debug logs #14650

Merged
merged 2 commits into from
Jun 5, 2023
Merged

[AGENT-9736] Added debug logs #14650

merged 2 commits into from
Jun 5, 2023

Conversation

vivek-datadog
Copy link
Contributor

@vivek-datadog vivek-datadog commented May 31, 2023

What does this PR do?

Added debug logs

  • while checking every disk partition returned from psutil
  • for excluded disks with size less than configured min disk size

Motivation

While debugging a support request AGENT-9736, the enumerated disks from psutil were not easy to comprehend. Also the disk check gets skipped when the disk size is < minimum configured disk size but the info is logged only when disk size is > 0. To get clarity on this information too a debug log is added.

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached
  • If the PR doesn't need to be tested during QA, please add a qa/skip-qa label.

@vivek-datadog vivek-datadog requested review from a team as code owners May 31, 2023 08:48
@ghost ghost added the integration/disk label May 31, 2023
@vivek-datadog vivek-datadog added changelog/no-changelog qa/skip-qa Automatically skip this PR for the next QA integration/disk and removed integration/disk labels May 31, 2023
@FlorentClarret FlorentClarret added changelog/Fixed and removed qa/skip-qa Automatically skip this PR for the next QA changelog/no-changelog labels May 31, 2023
Copy link
Member

@FlorentClarret FlorentClarret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Just changed the label to fixed because this will be shipped with the agent

@codecov
Copy link

codecov bot commented May 31, 2023

Codecov Report

Merging #14650 (50c2451) into master (07e3746) will decrease coverage by 1.82%.
The diff coverage is 100.00%.

❗ Current head 50c2451 differs from pull request most recent head 0cdf7d8. Consider uploading reports for the commit 0cdf7d8 to get more accurate results

Flag Coverage Δ
disk 89.19% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@github-actions
Copy link

github-actions bot commented May 31, 2023

Test Results

    8 files      8 suites   40s ⏱️
  49 tests   49 ✔️   0 💤 0
200 runs  190 ✔️ 10 💤 0

Results for commit 0cdf7d8.

♻️ This comment has been updated with latest results.

- every disk partition check from psutil
- excluded disk with size less than configured min disk size

Signed-off-by: Vivekanand Ilango <vivekanand.ilango@datadoghq.com>
@vivek-datadog vivek-datadog merged commit ed19865 into master Jun 5, 2023
@vivek-datadog vivek-datadog deleted the vivek/AGENT-9736 branch June 5, 2023 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants