-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NDM] [Cisco ACI] Support submitting topology metadata #18675
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zoedt
changed the title
[NDM] [Cisco ACI] Support topology metadata
[NDM] [Cisco ACI] Support submitting topology metadata
Sep 26, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. |
Fix pydantic model
zoedt
force-pushed
the
zoe/aci-topology
branch
from
September 26, 2024 17:40
06bc42a
to
b6609f6
Compare
zoedt
force-pushed
the
zoe/aci-topology
branch
from
September 27, 2024 15:18
a62358d
to
a50e00c
Compare
zoedt
force-pushed
the
zoe/aci-topology
branch
from
October 30, 2024 18:29
71138f9
to
7f71145
Compare
jmw51798
previously approved these changes
Nov 4, 2024
vicweiss
previously approved these changes
Nov 5, 2024
jmw51798
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
https://datadoghq.atlassian.net/browse/NDMII-2989
Adds support for sending
TopologyLinkMetadata
to our EvPndm
track to support having ACI devices appear on the topology map.See this document for additional context.
Changes summary
TopologyLinkMetadata
from responses, utilizingdevice_mapping
that references the pod name to the device ID (within Datadog) i.e. (pod-1-node-101
-->default:10.0.01
)network-device-writer
via DDSQL queriesQA Steps
Reference docs here for ddev QA
Output should incl.
Network Devices Monitoring metadata
withlinks
filled with expected fields and the data appearing on theTopology Map
in staging :-)Motivation
Additional Notes
Review checklist (to be filled by reviewers)
qa/skip-qa
label if the PR doesn't need to be tested during QA.backport/<branch-name>
label to the PR and it will automatically open a backport PR once this one is merged