Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 7.58.x] Bump RethinkDB version for python 3.12 (#18636) #18723

Merged
merged 3 commits into from
Oct 1, 2024

Conversation

Kyle-Neale
Copy link
Contributor

@Kyle-Neale Kyle-Neale commented Sep 30, 2024

What does this PR do?

Motivation

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Changelog entries must be created for modifications to shipped code
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

* test e2e with docker build of Agent with py 3.12.6

* test rethinkdb bump

* add fix for looseversion error

* add changelog and revert agent-dev image tag

(cherry picked from commit 0369667)
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

Copy link

codecov bot commented Sep 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (7.58.x@8754d37). Learn more about missing BASE report.

Additional details and impacted files
Flag Coverage Δ
rethinkdb 97.93% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@Kyle-Neale Kyle-Neale changed the title Bump RethinkDB version for python 3.12 (#18636) [Backport 7.58.x] Bump RethinkDB version for python 3.12 (#18636) Sep 30, 2024
@Kyle-Neale Kyle-Neale marked this pull request as ready for review September 30, 2024 16:53
@Kyle-Neale Kyle-Neale requested a review from a team as a code owner September 30, 2024 16:53
@Kyle-Neale Kyle-Neale changed the base branch from 7.58.x to backport-18212-to-7.58.x September 30, 2024 16:56
@Kyle-Neale Kyle-Neale changed the base branch from backport-18212-to-7.58.x to master September 30, 2024 17:08
@Kyle-Neale Kyle-Neale requested review from a team as code owners September 30, 2024 17:08
@Kyle-Neale Kyle-Neale changed the base branch from master to backport-18212-to-7.58.x September 30, 2024 17:17
Base automatically changed from backport-18212-to-7.58.x to 7.58.x September 30, 2024 18:04
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@Kyle-Neale Kyle-Neale merged commit bb91eaf into 7.58.x Oct 1, 2024
29 of 31 checks passed
@Kyle-Neale Kyle-Neale deleted the back-port-18636-to-7.58.x branch October 1, 2024 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment