Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AI-4451] Add Milvus integration #19055

Merged
merged 31 commits into from
Dec 24, 2024
Merged

[AI-4451] Add Milvus integration #19055

merged 31 commits into from
Dec 24, 2024

Conversation

dkirov-dd
Copy link
Contributor

What does this PR do?

Motivation

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

1 similar comment
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@dkirov-dd dkirov-dd changed the title Add Milvus integration [AI-4451] Add Milvus integration Nov 14, 2024
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

Attention: Patch coverage is 92.30769% with 5 lines in your changes missing coverage. Please review.

Project coverage is 89.45%. Comparing base (66d9280) to head (e2e1b5f).
Report is 216 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
activemq ?
cassandra ?
hive ?
hivemq ?
hudi ?
ignite ?
jboss_wildfly ?
kafka ?
milvus 92.30% <92.30%> (?)
presto ?
solr ?

Flags with carried forward coverage won't be shown. Click here to find out more.

@dkirov-dd dkirov-dd closed this Nov 19, 2024
@dkirov-dd dkirov-dd reopened this Nov 20, 2024
milvus/README.md Outdated Show resolved Hide resolved
milvus/README.md Outdated Show resolved Hide resolved
milvus/README.md Outdated Show resolved Hide resolved
milvus/metadata.csv Outdated Show resolved Hide resolved
milvus/metadata.csv Outdated Show resolved Hide resolved
milvus/metadata.csv Outdated Show resolved Hide resolved
milvus/metadata.csv Outdated Show resolved Hide resolved
milvus/metadata.csv Outdated Show resolved Hide resolved
milvus/metadata.csv Outdated Show resolved Hide resolved
milvus/metadata.csv Outdated Show resolved Hide resolved
@dkirov-dd dkirov-dd requested a review from steveny91 December 18, 2024 09:47
dkirov-dd and others added 2 commits December 19, 2024 15:07
Co-authored-by: Ursula Chen <58821586+urseberry@users.noreply.github.com>
@dkirov-dd dkirov-dd requested a review from urseberry December 19, 2024 14:15
milvus/metadata.csv Outdated Show resolved Hide resolved
milvus/metadata.csv Outdated Show resolved Hide resolved
milvus/metadata.csv Outdated Show resolved Hide resolved
milvus/metadata.csv Outdated Show resolved Hide resolved
milvus/metadata.csv Outdated Show resolved Hide resolved
milvus/metadata.csv Outdated Show resolved Hide resolved
milvus/metadata.csv Outdated Show resolved Hide resolved
milvus/metadata.csv Outdated Show resolved Hide resolved
milvus/metadata.csv Outdated Show resolved Hide resolved
milvus/metadata.csv Outdated Show resolved Hide resolved
@dkirov-dd dkirov-dd force-pushed the david.kirov/milvus branch 4 times, most recently from a188f2b to 00b46f8 Compare December 23, 2024 11:52
@dkirov-dd dkirov-dd added this pull request to the merge queue Dec 24, 2024
Merged via the queue into master with commit 1cb058e Dec 24, 2024
46 of 47 checks passed
@dkirov-dd dkirov-dd deleted the david.kirov/milvus branch December 24, 2024 15:53
github-actions bot pushed a commit that referenced this pull request Dec 24, 2024
* Add Milvus skeleton

* Add metrics to metadata.csv

* Add periods in metadata.csv

* Update spec

* Update config models

* Update manifest

* Update check.py

* Add process signature

* Add units in metadata.csv

* Remove process signature

* Add payload fixture

* Add tests

* Fix metadata.csv

* Add non-Milvus specific metrics

* Update metrics map

* Expand histogram metrics

* Fix metrics mapping and divide test metrics

* Passing unit tests

* Add e2e env and test

* Run lint

* Fix CI

* Switch to deprecated classifier tags for CI

* Sync labeler

* Remove dashboard and add metric check

* Implement review suggestions

* Incorporate documentation suggestions

* Capitalize unix in metadata description

Co-authored-by: Ursula Chen <58821586+urseberry@users.noreply.github.com>

* Incorporate documentation suggestions

* Move metrics out of standalone test

* Fix unit tests

* Improve README

---------

Co-authored-by: Ursula Chen <58821586+urseberry@users.noreply.github.com> 1cb058e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants