Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mysql.innodb.row_lock_time metric unit #19091

Merged
merged 3 commits into from
Dec 17, 2024
Merged

Conversation

rashiq
Copy link
Contributor

@rashiq rashiq commented Nov 20, 2024

What does this PR do?

Changing the unit and description of mysql.innodb.row_lock_time.

Motivation

The metric is ingested based on this status variable. It's in miliseconds and collects the total time spent on acquiring row locks.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.56%. Comparing base (1c45b74) to head (e7bacf6).
Report is 11 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
cassandra ?
hivemq ?
hudi ?
jboss_wildfly ?
mysql 89.48% <ø> (-0.04%) ⬇️
weblogic ?

Flags with carried forward coverage won't be shown. Click here to find out more.

@rashiq
Copy link
Contributor Author

rashiq commented Nov 21, 2024

Hi @lu-zhengda! Thank you for your review. It tells me it still needs a review from someone from the DataDog/agent-integrations team. Is there someone I can request a review from?

@lu-zhengda lu-zhengda added this pull request to the merge queue Nov 21, 2024
@lu-zhengda
Copy link
Contributor

Hi @rashiq, thanks for submitting the fix. You are good on the review. I will merge the PR shortly.

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Nov 21, 2024
@lu-zhengda lu-zhengda added this pull request to the merge queue Dec 12, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Dec 12, 2024
@lu-zhengda lu-zhengda added this pull request to the merge queue Dec 17, 2024
Merged via the queue into DataDog:master with commit fc33628 Dec 17, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants