Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PLINT-543] Add support for environment metrics and tagging by environment, deployment, and release #19192

Merged

Conversation

sarah-witt
Copy link
Contributor

@sarah-witt sarah-witt commented Dec 4, 2024

What does this PR do?

Handles collecting environment metrics as well as tagging deployment metrics more effectively.

  • Collect environment metrics in octopus integration
  • adds tags to deployment metrics and logs for environments, releases, and deployments
  • adds caching for this information to limit the amount of API calls.
  • filters deployment metrics and logs via the environments config option
  • only requests tasks named "Deploy" to skip runbook tasks
  • removes unneeded task_id (high variance and not very informative) and task_name (will always be deploy) tags

Motivation

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

Copy link

codecov bot commented Dec 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.36%. Comparing base (e0312a0) to head (b892286).
Report is 1 commits behind head on sarah/add-octopus-integration.

Additional details and impacted files
Flag Coverage Δ
octopus_deploy 99.06% <100.00%> (+1.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@sarah-witt sarah-witt marked this pull request as ready for review December 5, 2024 15:43
@sarah-witt sarah-witt requested review from a team as code owners December 5, 2024 15:43
@rahulkaukuntla rahulkaukuntla self-requested a review December 18, 2024 15:17
@sarah-witt sarah-witt merged commit 02785fd into sarah/add-octopus-integration Dec 20, 2024
20 checks passed
@sarah-witt sarah-witt deleted the sarah/add-support-environments branch December 20, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants