Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add schema tag to db_fragmentation metrics for sqlserver #19277

Merged

Conversation

azhou-datadog
Copy link
Contributor

What does this PR do?

A follow up to #19266. It is also very convenient to have the schema tag attached to db fragmentation metrics for sqlserver as well.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.00%. Comparing base (ac01180) to head (83fc67b).
Report is 2 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
activemq ?
cassandra ?
hive ?
hivemq ?
hudi ?
ignite ?
jboss_wildfly ?
kafka ?
presto ?
solr ?
sqlserver 91.15% <100.00%> (+9.50%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@azhou-datadog azhou-datadog added this pull request to the merge queue Dec 17, 2024
@azhou-datadog azhou-datadog added the qa/skip-qa Automatically skip this PR for the next QA label Dec 17, 2024
Merged via the queue into master with commit 5a82ab2 Dec 17, 2024
40 checks passed
@azhou-datadog azhou-datadog deleted the allen.zhou/schema_name_for_more_metrics_sqlserver branch December 17, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants