Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sy/keda #19303

Merged
merged 14 commits into from
Dec 24, 2024
Merged

Sy/keda #19303

merged 14 commits into from
Dec 24, 2024

Conversation

steveny91
Copy link
Contributor

@steveny91 steveny91 commented Dec 24, 2024 •
edited
Loading

What does this PR do?

Keda implementation.

  • Just python code and tests

Separate PRs will be made for:

  • Docs and metadata entries
  • Dashboard
  • Logs
  • Saved Views
  • Process Signature
  • Recommended Monitors

@codecov Codecov
Copy link

codecov bot commented Dec 24, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 88.05970% with 8 lines in your changes missing coverage. Please review.

Project coverage is 87.28%. Comparing base (6c3294c) to head (76d7016).
Report is 63 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
activemq ?
cassandra ?
hive ?
hivemq ?
hudi ?
ignite ?
jboss_wildfly ?
kafka ?
keda 88.05% <88.05%> (?)
presto ?
solr ?

Flags with carried forward coverage won't be shown. Click here to find out more.

@steveny91 steveny91 marked this pull request as ready for review December 24, 2024 14:49
@steveny91 steveny91 requested review from a team as code owners December 24, 2024 14:49
Kyle-Neale
Kyle-Neale reviewed Dec 24, 2024
View reviewed changes
keda/datadog_checks/keda/metrics.py
'go_memstats_lookups': 'go.memstats.lookups',
'go_memstats_mallocs': 'go.memstats.mallocs',
'go_memstats_mcache_inuse_bytes': 'go.memstats.mcache.inuse_bytes',
'go_memstats_mcache_sys_bytes': 'go.memstats.mcache.sys_bytes',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT. In the future, we should use the DEFAULT_GO_METRICS constant to handle these generic go metrics.

@steveny91 steveny91 added this pull request to the merge queue Dec 24, 2024
Merged via the queue into master with commit 642b2f9 Dec 24, 2024
52 of 54 checks passed
@steveny91 steveny91 deleted the sy/keda branch December 24, 2024 21:48
github-actions bot pushed a commit that referenced this pull request Dec 24, 2024
@github-merge-queue
Sy/keda (#19303)
c35e01a 
* initial commit

* update metrics

* fixtures and other small assets

* tests and assets

* lint

* validations

* Rename 1.added to 19303.added

* place holder dash

* fix test

* fix test

* slight rename

* change metric to check

* fix test

* rename test metric 642b2f9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kyle-Neale Kyle-Neale Kyle-Neale left review comments

@HadhemiDD HadhemiDD HadhemiDD approved these changes

@buraizu buraizu buraizu approved these changes

Assignees
No one assigned
Labels
agent/approved docs/approved ecosystems/review-requested product/review-requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@steveny91 @buraizu @Kyle-Neale @HadhemiDD