-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Supabase integration #19307
base: master
Are you sure you want to change the base?
Supabase integration #19307
Conversation
# (C) Datadog, Inc. 2024-present | ||
# All rights reserved | ||
# Licensed under a 3-clause BSD style license (see LICENSE) | ||
from datadog_checks.base.checks.openmetrics.v2.metrics import DEFAULT_GO_METRICS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only thing I'd say we should do differently here is to change this metric:
integrations-core/datadog_checks_base/datadog_checks/base/checks/openmetrics/v2/metrics.py
Line 31 in 642b2f9
'process_start_time_seconds': 'process.start_time.seconds', |
We should make it an elapsed time metric. I can do that. But then we'd have to make a release and bump the min base package in this check. The easier way maybe to overwrite the metric in your metric list.
What does this PR do?
Supabase implementation.
Separate PRs will be made for: