Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Test command line result before comparing it to Gunicorn master name #19310

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dax
Copy link

@dax dax commented Dec 26, 2024

What does this PR do?

It tests the result of psutil.cmdline() before comparing its first element to the Gunicorn master process name.

Motivation

On Linux psutil.cmdline() may return an empty array (e.g. for kernel processes) making cmdline()[0] crash with an IndexError: list index out of range error.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

Copy link

codecov bot commented Dec 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.63%. Comparing base (642b2f9) to head (f3228c0).

Additional details and impacted files
Flag Coverage Δ
activemq ?
cassandra ?
gunicorn 91.41% <100.00%> (-0.75%) ⬇️
hive ?
hivemq ?
hudi ?
ignite ?
jboss_wildfly ?
kafka ?
presto ?
solr ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant