Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SNMP] Update topology link metadata tests #19311

Merged
merged 1 commit into from
Dec 26, 2024

Conversation

TCheruy
Copy link
Contributor

@TCheruy TCheruy commented Dec 26, 2024

What does this PR do?

We now pass the integration field in topology links, this PR updates the tests to reflect this.

Motivation

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

Copy link

codecov bot commented Dec 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.63%. Comparing base (642b2f9) to head (9aa13db).
Report is 2 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
activemq ?
cassandra ?
hive ?
hivemq ?
hudi ?
ignite ?
jboss_wildfly ?
kafka ?
presto ?
snmp 95.71% <ø> (-0.02%) ⬇️
solr ?

Flags with carried forward coverage won't be shown. Click here to find out more.

@TCheruy TCheruy added this pull request to the merge queue Dec 26, 2024
Merged via the queue into master with commit a43971a Dec 26, 2024
44 of 45 checks passed
@TCheruy TCheruy deleted the ThibaudC/update-snmp-tests-topology-metadata branch December 26, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants