Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VPA metrics to kubernetes_state integration #4353

Merged
merged 3 commits into from
Aug 22, 2019
Merged

Conversation

dturn
Copy link
Contributor

@dturn dturn commented Aug 12, 2019

What does this PR do?

Adds the recently added Vertical Pod Autoscaler (VPA) metrics from Kubernetes State Metrics, kubernetes/kube-state-metrics#791, to the ksm integration.

Motivation

We'd like to have these metrics. When we contacted support (https://help.datadoghq.com/hc/en-us/requests/226107) we were informed this was not on the roadmap, so we assumed the next step was to do it ourselves.

Additional Notes

I used the PR that added HPA metrics as a guide #801. I also wasn't sure what metrics I should import, explicitly/implicitly ignore, and if any transformations would be helpful.

Review checklist (to be filled by reviewers)

  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached
  • Feature or bugfix must have tests
  • Git history must be clean
  • If PR adds a configuration option, it must be added to the configuration file.

@dturn dturn requested review from a team as code owners August 12, 2019 22:24
@dturn
Copy link
Contributor Author

dturn commented Aug 16, 2019

@hkaj Are you the right person to review this? If not, could you please suggest someone. Thank you.

Copy link
Contributor

@ofek ofek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dturn Thanks for this! I left a few suggestions that should make the CI pass.

kubernetes_state/metadata.csv Outdated Show resolved Hide resolved
kubernetes_state/metadata.csv Outdated Show resolved Hide resolved
kubernetes_state/metadata.csv Outdated Show resolved Hide resolved
kubernetes_state/metadata.csv Outdated Show resolved Hide resolved
kubernetes_state/metadata.csv Outdated Show resolved Hide resolved
dturn and others added 2 commits August 21, 2019 09:26
PR feedback

Co-Authored-By: Ofek Lev <ofekmeister@gmail.com>
@ofek ofek merged commit 6eb4b2d into DataDog:master Aug 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants