Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweak MySQL logs setup #5222

Merged
merged 2 commits into from
Dec 16, 2019
Merged

Tweak MySQL logs setup #5222

merged 2 commits into from
Dec 16, 2019

Conversation

florimondmanca
Copy link
Contributor

What does this PR do?

  • Add missing config file for MySQL 8.0
  • Explicit set log file paths for all tested MySQL versions/flavors.

Motivation

Cleanup for #5186, pre-requisite for #5218.

Additional Notes

/

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@florimondmanca florimondmanca requested a review from a team as a code owner December 16, 2019 17:42
@florimondmanca florimondmanca mentioned this pull request Dec 16, 2019
Merged
8 tasks
FlorianVeaux
FlorianVeaux approved these changes Dec 16, 2019
View reviewed changes
Copy link
Member

@FlorianVeaux FlorianVeaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI will probably fail because of an issue with the coverage library, but let's make sure all the tests are green in the logs before merging.

Beside that, all good 💯

@florimondmanca
Copy link
Contributor Author

CI finished:

@florimondmanca florimondmanca merged commit ff457c0 into master Dec 16, 2019
@florimondmanca florimondmanca deleted the florimondmanca/mysql-log-config-fixes branch December 16, 2019 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FlorianVeaux FlorianVeaux FlorianVeaux approved these changes

Assignees
No one assigned
Labels
changelog/no-changelog integration/mysql
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@florimondmanca @FlorianVeaux