PureFB v2.0.1 - rename incorrectly named metric (#2442)

* rename incorrectly named metric

* Update purefb/CHANGELOG.md

Co-authored-by: emarsha94 <52013262+emarsha94@users.noreply.github.com>

---------

Co-authored-by: emarsha94 <52013262+emarsha94@users.noreply.github.com>

purefb/CHANGELOG.md

@@ -1,5 +1,10 @@
 # CHANGELOG - PureFB
 
+## 2.0.1 / 2024-07-22
+
+* Renamed incorrectly named metric to correctly align with metrics namings and instrument standards.
+`purefb.clients_performance_average_bytes` to `purefb.clients.performance_average_bytes`
+
 ## 2.0.0 / 2024-06-26
 
 ***Added***: 

purefb/assets/dashboards/purefb_overview.json

@@ -300,7 +300,7 @@
          "id":1279538407923410,
          "definition":{
             "type":"note",
-            "content":"## Metrics\n\n`All metrics are prefixed with purefb.`\n\nBelow are the metrics names available:\n\n### Collected with /metrics/array, collected every 60s, by default\n\n    * info\n    * alerts.open\n    * hardware.health\n    * array.http_specific_performance_latency_usec\n    * array.http_specific_performance_throughput_iops\n    * array.nfs_specific_performance_latency_usec\n    * array.nfs_specific_performance_throughput_iops\n    * array.performance_average_bytes\n    * array.performance_bandwidth_bytes\n    * array.performance_latency_usec\n    * array.performance_replication\n    * array.performance_throughput_iops\n    * array.s3_specific_performance_latency_usec\n    * array.s3_specific_performance_throughput_iops\n    * array.space_bytes\n    * array.space_data_reduction_ratio\n    * array.space_parity\n    * buckets.object_count\n    * buckets.performance_average_bytes\n    * buckets.performance_bandwidth_bytes\n    * buckets.performance_latency_usec\n    * buckets.performance_throughput_iops\n    * buckets.s3_specific_performance_latency_usec\n    * buckets.s3_specific_performance_throughput_iops\n    * buckets.space_bytes\n    * buckets.space_data_reduction_ratio\n    * buckets.quota_space_bytes\n    * file.systems_performance_average_bytes\n    * file.systems_performance_bandwidth_bytes\n    * file.systems_performance_latency_usec\n    * file.systems_performance_throughput_iops\n    * file.systems_space_bytes\n    * file.systems_space_data_reduction_ratio\n    * hardware.connectors_performance_bandwidth_bytes\n    * hardware.connectors_performance_errors\n    * hardware.connectors_performance_throughput_pkts\n\n### Collected with /metrics/usage, collected every 600s, by default \n    * file.system_usage_groups_bytes\n    * file.system_usage_users_bytes\n    \n### Collected with /metrics/clients, collected every 600s, by default\n    * clients_performance_average_bytes\n    * clients.performance_bandwidth_bytes\n    * clients.performance_latency_usec\n    * clients.performance_throughput_iops",
+            "content":"## Metrics\n\n`All metrics are prefixed with purefb.`\n\nBelow are the metrics names available:\n\n### Collected with /metrics/array, collected every 60s, by default\n\n    * info\n    * alerts.open\n    * hardware.health\n    * array.http_specific_performance_latency_usec\n    * array.http_specific_performance_throughput_iops\n    * array.nfs_specific_performance_latency_usec\n    * array.nfs_specific_performance_throughput_iops\n    * array.performance_average_bytes\n    * array.performance_bandwidth_bytes\n    * array.performance_latency_usec\n    * array.performance_replication\n    * array.performance_throughput_iops\n    * array.s3_specific_performance_latency_usec\n    * array.s3_specific_performance_throughput_iops\n    * array.space_bytes\n    * array.space_data_reduction_ratio\n    * array.space_parity\n    * buckets.object_count\n    * buckets.performance_average_bytes\n    * buckets.performance_bandwidth_bytes\n    * buckets.performance_latency_usec\n    * buckets.performance_throughput_iops\n    * buckets.s3_specific_performance_latency_usec\n    * buckets.s3_specific_performance_throughput_iops\n    * buckets.space_bytes\n    * buckets.space_data_reduction_ratio\n    * buckets.quota_space_bytes\n    * file.systems_performance_average_bytes\n    * file.systems_performance_bandwidth_bytes\n    * file.systems_performance_latency_usec\n    * file.systems_performance_throughput_iops\n    * file.systems_space_bytes\n    * file.systems_space_data_reduction_ratio\n    * hardware.connectors_performance_bandwidth_bytes\n    * hardware.connectors_performance_errors\n    * hardware.connectors_performance_throughput_pkts\n\n### Collected with /metrics/usage, collected every 600s, by default \n    * file.system_usage_groups_bytes\n    * file.system_usage_users_bytes\n    \n### Collected with /metrics/clients, collected every 600s, by default\n    * clients.performance_average_bytes\n    * clients.performance_bandwidth_bytes\n    * clients.performance_latency_usec\n    * clients.performance_throughput_iops",
             "background_color":"white",
             "font_size":"14",
             "text_align":"left",

purefb/datadog_checks/purefb/metrics.py

@@ -32,7 +32,7 @@
         },
         'purefb_buckets_space_bytes': {'name': 'buckets.space_bytes'},
         'purefb_buckets_space_data_reduction_ratio': {'name': 'buckets.space_data_reduction_ratio'},
-        'purefb_clients_performance_average_bytes': {'name': 'clients_performance_average_bytes'},
+        'purefb_clients_performance_average_bytes': {'name': 'clients.performance_average_bytes'},
         'purefb_clients_performance_bandwidth_bytes': {'name': 'clients.performance_bandwidth_bytes'},
         'purefb_clients_performance_latency_usec': {'name': 'clients.performance_latency_usec'},
         'purefb_clients_performance_throughput_iops': {'name': 'clients.performance_throughput_iops'},

purefb/metadata.csv

@@ -25,7 +25,7 @@ purefb.buckets.s3_specific_performance_latency_usec,gauge,,microsecond,,FlashBla
 purefb.buckets.s3_specific_performance_throughput_iops,gauge,,operation,second,FlashBlade buckets S3 specific throughput,0,purefb,buckets s3 specific performance throughput iops,
 purefb.buckets.space_bytes,gauge,,byte,,FlashBlade buckets space in bytes,0,purefb,buckets space bytes,
 purefb.buckets.space_data_reduction_ratio,gauge,,,,FlashBlade buckets space data reduction,0,purefb,buckets space data reduction ratio,
-purefb.clients_performance_average_bytes,gauge,,byte,,FlashBlade array clients average operations size,0,purefb,array clients performance avg size bytes,
+purefb.clients.performance_average_bytes,gauge,,byte,,FlashBlade array clients average operations size,0,purefb,array clients performance avg size bytes,
 purefb.clients.performance_bandwidth_bytes,gauge,,byte,second,FlashBlade array clients bandwidth,0,purefb,array clients performance bandwidth bytes,
 purefb.clients.performance_latency_usec,gauge,,microsecond,,FlashBlade array clients latency,-1,purefb,array clients performance latency usec,
 purefb.clients.performance_throughput_iops,gauge,,operation,second,FlashBlade array clients throughput,0,purefb,array clients performance throughput iops,