Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Modal integration tile #2435

Merged

Conversation

irfansharif
Copy link
Contributor

  • Update the default dashboard.
  • Update the product hero (we made some changes to our UI).
  • Update the README to mention that we're not (yet) collecting metrics.

What does this PR do?

We're now also collecting function logs. Update things to reflect as much.

Motivation

See above.

Review checklist

  • PR has a meaningful title or PR has the no-changelog label attached
  • [/] Feature or bugfix has tests
  • Git history is clean
  • If PR impacts documentation, docs team has been notified or an issue has been opened on the documentation repo
  • [/] If this PR includes a log pipeline, please add a description describing the remappers and processors.

Additional Notes

Anything else we should know when reviewing?

@irfansharif irfansharif force-pushed the irfansharif/240709.update-integration branch from db445dd to 5c6110a Compare July 9, 2024 17:05
@irfansharif
Copy link
Contributor Author

+cc @pawalt.

Copy link
Contributor

@aliciascott aliciascott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @irfansharif just a minor suggestion, please let me know once updated and I'll approve :)

modal/README.md Outdated Show resolved Hide resolved
We're now also collecting function logs. Update things to reflect as
much.
- Update the default dashboard.
- Update the product hero (we made some changes to our UI).
- Update the README to mention that we're not (yet) collecting metrics.
@irfansharif irfansharif force-pushed the irfansharif/240709.update-integration branch from b8046dd to 05a01f3 Compare July 11, 2024 19:22
Copy link
Contributor Author

@irfansharif irfansharif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@emarsha94 emarsha94 requested review from a team and moreauowen and removed request for nmuesch and a team August 28, 2024 13:56
@moreauowen moreauowen merged commit 1e8adc2 into DataDog:master Aug 28, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants