-
Notifications
You must be signed in to change notification settings - Fork 724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Modal integration tile #2435
Merged
moreauowen
merged 1 commit into
DataDog:master
from
modal-labs:irfansharif/240709.update-integration
Aug 28, 2024
Merged
Update Modal integration tile #2435
moreauowen
merged 1 commit into
DataDog:master
from
modal-labs:irfansharif/240709.update-integration
Aug 28, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
db445dd
to
5c6110a
Compare
+cc @pawalt. |
5c6110a
to
15fba4a
Compare
emarsha94
approved these changes
Jul 11, 2024
aliciascott
requested changes
Jul 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @irfansharif just a minor suggestion, please let me know once updated and I'll approve :)
We're now also collecting function logs. Update things to reflect as much. - Update the default dashboard. - Update the product hero (we made some changes to our UI). - Update the README to mention that we're not (yet) collecting metrics.
b8046dd
to
05a01f3
Compare
irfansharif
commented
Jul 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
emarsha94
approved these changes
Jul 15, 2024
emarsha94
requested changes
Jul 15, 2024
aliciascott
approved these changes
Jul 15, 2024
emarsha94
approved these changes
Aug 28, 2024
moreauowen
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
We're now also collecting function logs. Update things to reflect as much.
Motivation
See above.
Review checklist
no-changelog
label attachedAdditional Notes
Anything else we should know when reviewing?