-
Notifications
You must be signed in to change notification settings - Fork 730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Perfectscale] add medadata.csv with metric description #2448
Conversation
perfectscale/metadata.csv
Outdated
@@ -0,0 +1,2 @@ | |||
metric_name,metric_type,interval,unit_name,per_unit_name,description,orientation,integration,short_name,curated_metric | |||
perfectscale.alert.metric,count,,,,The number of alerts by cluster,0,perfectscale,alert.metric, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To confirm, you only send in 1 metric?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@idan-gazit Can you confirm the integration only sends one metric? The overview says the integration sends in the following:
"PerfectScale monitors resiliency metrics across your Kubernetes environment and sends these metrics to Datadog through the Integration. When PerfectScale identifies under-provisioned or misconfigured workloads, it promptly pushes an alert to the Datadog dashboard detailing the issue type (such as OOM, CPU-Throttling, Eviction, and more) along with its precise location (cluster, namespace, workload, and container)."
This integration metadata file says it's only sending the metric that counts the number of alerts by clusters. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes @emarsha94
We are sending only perfectscale.alert.metric.
@emarsha94 we passed all check, could you review again? |
What does this PR do?
Add medadata.csv with metric description
Motivation
this file was missed
Review checklist
no-changelog
label attachedAdditional Notes