Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Perfectscale] add medadata.csv with metric description #2448

Merged
merged 44 commits into from
Aug 6, 2024

Conversation

oveleten
Copy link
Contributor

@oveleten oveleten commented Jul 22, 2024

What does this PR do?

Add medadata.csv with metric description

Motivation

this file was missed

Review checklist

  • PR has a meaningful title or PR has the no-changelog label attached
  • Feature or bugfix has tests
  • Git history is clean
  • If PR impacts documentation, docs team has been notified or an issue has been opened on the documentation repo
  • If this PR includes a log pipeline, please add a description describing the remappers and processors.

Additional Notes

@oveleten oveleten requested a review from a team as a code owner July 22, 2024 21:27
@oveleten oveleten requested a review from mgarabed July 22, 2024 21:27
perfectscale/manifest.json Outdated Show resolved Hide resolved
@@ -0,0 +1,2 @@
metric_name,metric_type,interval,unit_name,per_unit_name,description,orientation,integration,short_name,curated_metric
perfectscale.alert.metric,count,,,,The number of alerts by cluster,0,perfectscale,alert.metric,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To confirm, you only send in 1 metric?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@idan-gazit Can you confirm the integration only sends one metric? The overview says the integration sends in the following:

"PerfectScale monitors resiliency metrics across your Kubernetes environment and sends these metrics to Datadog through the Integration. When PerfectScale identifies under-provisioned or misconfigured workloads, it promptly pushes an alert to the Datadog dashboard detailing the issue type (such as OOM, CPU-Throttling, Eviction, and more) along with its precise location (cluster, namespace, workload, and container)."

This integration metadata file says it's only sending the metric that counts the number of alerts by clusters. Thanks!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes @emarsha94
We are sending only perfectscale.alert.metric.

@oveleten oveleten requested a review from emarsha94 August 5, 2024 16:29
@oveleten oveleten requested a review from emarsha94 August 5, 2024 17:41
@oveleten
Copy link
Contributor Author

oveleten commented Aug 5, 2024

@emarsha94 we passed all check, could you review again?

@nmuesch nmuesch added the assets/no-deploy Prevents APW from deploying this PR in staging label Aug 5, 2024
@moreauowen moreauowen merged commit b26adc4 into DataDog:master Aug 6, 2024
26 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants