-
Notifications
You must be signed in to change notification settings - Fork 724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add CloudQuery integration (ECOINT-11) #2451
base: master
Are you sure you want to change the base?
Conversation
adf28ee
to
f7469b0
Compare
f7469b0
to
9677e2f
Compare
Created Jira card for Docs Team review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some suggestions for documentation, let me know if you have any questions or would like a re-review!
Co-authored-by: Esther Kim <esthercodes2019@gmail.com>
Co-authored-by: Esther Kim <esthercodes2019@gmail.com>
Co-authored-by: Esther Kim <esthercodes2019@gmail.com>
Co-authored-by: Esther Kim <esthercodes2019@gmail.com>
Co-authored-by: Esther Kim <esthercodes2019@gmail.com>
Co-authored-by: Esther Kim <esthercodes2019@gmail.com>
Co-authored-by: Esther Kim <esthercodes2019@gmail.com>
Co-authored-by: Esther Kim <esthercodes2019@gmail.com>
Co-authored-by: Esther Kim <esthercodes2019@gmail.com>
Co-authored-by: Esther Kim <esthercodes2019@gmail.com>
Co-authored-by: Esther Kim <esthercodes2019@gmail.com>
Co-authored-by: Esther Kim <esthercodes2019@gmail.com>
Co-authored-by: Esther Kim <esthercodes2019@gmail.com>
Co-authored-by: Esther Kim <esthercodes2019@gmail.com>
Co-authored-by: Esther Kim <esthercodes2019@gmail.com>
Co-authored-by: Esther Kim <esthercodes2019@gmail.com>
Thanks for the review @estherk15, great suggestions 🚀 I also followed up with 087f84a and 06a21ee to fix the links and lists numbering (as the lists numbering is not preserved after the code blocks). |
Thanks @estherk15, per a meeting with the team in charge of partner integrations, we'll submit this as a community integration until there's official OTEL support |
OK so I guess I got confused by something, since the instructions in https://docs.datadoghq.com/agent/guide/use-community-integrations/?tab=agentv721v621 say to open a PR to this repo. Can we accept this PR as a community integration? Please note this integration does not require any installation on the agent side |
Moving to draft until I fix the log pipelines CI |
#### Summary This adds a new section to our Datadog dashboard with information on throttled APIs: ![image](https://github.com/user-attachments/assets/fda9fcfe-7d3c-4e42-a134-95890e64243a) Clicking on a column will users open the logs in the relevant location: ![image](https://github.com/user-attachments/assets/e9b931b0-9074-467f-ad4a-b9ec4cd929f5) ![image](https://github.com/user-attachments/assets/06d2c975-df01-4a99-8446-317eb1b56c5d) I've also added the the same change to DataDog/integrations-extras#2451. DataDog/integrations-extras#2451 also adds custom log pipelines to extract the retry attempts into attributes instead of relying on the `retrying request` message. However if we only distribute the dashboard (like we do on our website) we can't ship the pipelines with the dashboard (we need the integration for that).
9b1009a
to
cf8f3b1
Compare
OK, removed the log pipelines in the initial version, I'll add those later |
14209ec marks this as a community integration |
What does this PR do?
Add CloudQuery integration
Motivation
Get listed on the integrations page per https://docs.datadoghq.com/developers/integrations/?tab=integrations
Review checklist
no-changelog
label attachedAdditional Notes
Anything else we should know when reviewing?
I followed the guide in https://docs.datadoghq.com/developers/integrations/?tab=integrations as best as I can. Feedback welcomed!