Add a new OceanBase Cloud Integration (ECOINT-7) #2456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cswatt
added
the
editorial review
|
Added DOCS-8606 to review |
buraizu
requested changes
Aug 9, 2024
datadog-assets
bot
added
docs/requested-changes
and removed
docs/review-requested
labels
buraizu
approved these changes
Aug 20, 2024
emarsha94
requested changes
Aug 23, 2024
datadog-assets
bot
added
product/requested-changes
and removed
product/review-requested
labels
DrkSephy
approved these changes
Aug 26, 2024
emarsha94
requested changes
Aug 30, 2024
|
@emarsha94 Hello, may I ask if there are any other content that need revised? Can it be approved now? |
dd-dominic
changed the title
emarsha94
added
agent/requested-changes
agent/review-requested
and removed
agent/requested-changes
labels
emarsha94
reviewed
Sep 24, 2024
emarsha94
approved these changes
Sep 24, 2024
HadhemiDD
approved these changes
Sep 26, 2024
emarsha94
requested review from
a team and
JoshPatel13
and removed request for
a team
JoshPatel13
reviewed
Sep 30, 2024
| ], | ||
| "client_role": "integration", | ||
| "name": "oceanbasecloud", | ||
| "onboarding_url": "http://oceanbasei-lupr-tern.dev.alipay.net/integrations/Datadog", |
There was a problem hiding this comment.
This needs to be updated to a prod link since this is currently a dev link
JoshPatel13
reviewed
Sep 30, 2024
| "onboarding_url": "http://oceanbasei-lupr-tern.dev.alipay.net/integrations/Datadog", | ||
| "description": "oceanbasecloud oauth", | ||
| "redirect_uris": [ | ||
| "https://oceanbaseintlconsole-main.test.alipay.net/integrations/Datadog" |
There was a problem hiding this comment.
Same here. This should be a prod link instead of test :)
JoshPatel13
reviewed
Sep 30, 2024
oceanbasecloud/manifest.json
Outdated
| "creates_events": false | ||
| }, | ||
| "metrics": { | ||
| "prefix": "oceanbase_cloud", |
There was a problem hiding this comment.
This should be oceanbase_cloud. (add a period on the end)
There was a problem hiding this comment.
All fixed , please take a look again , thanks ~
JoshPatel13
approved these changes
Oct 3, 2024
datadog-assets
bot
added
ecosystems/approved
and removed
ecosystems/review-requested
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add a new integration for OceanBase Cloud.
Motivation
OceanBase Cloud provides fully managed database services with elastic scalability, ultra-fast performance, and high compatibility on global cloud infrastructure.
We Use the OceanBase Cloud Datadog integration to export metrics from OceanBase Cloud clusters to Datadog
This is an API based integration, which should only be installed in OceanBase Cloud environments.
What inspired you to submit this pull request?
Our users want to use datadog to monitor their OceanBase Cloud Clusters.
Review checklist
no-changeloglabel attached