-
Notifications
You must be signed in to change notification settings - Fork 724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a new OceanBase Cloud Integration (ECOINT-7) #2456
base: master
Are you sure you want to change the base?
Conversation
Co-authored-by: Bryce Eadie <bryce.eadie@datadoghq.com>
Co-authored-by: Bryce Eadie <bryce.eadie@datadoghq.com>
Co-authored-by: Bryce Eadie <bryce.eadie@datadoghq.com>
Co-authored-by: Bryce Eadie <bryce.eadie@datadoghq.com>
Co-authored-by: Bryce Eadie <bryce.eadie@datadoghq.com>
Co-authored-by: Bryce Eadie <bryce.eadie@datadoghq.com>
Co-authored-by: Bryce Eadie <bryce.eadie@datadoghq.com>
Added DOCS-8606 to review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for following up, requested some minor edits and posted a couple of questions on the updated doc
oceanbasecloud/README.md
Outdated
To set up the OceanBase Cloud Datadog integration for your cluster, please refer to the following steps | ||
1. Log in to the OceanBase Cloud console, go to [OceanBase Cloud Integrations][3], and search the Datadog product. | ||
2. Click the connect button ,the page will redirect you to the Datadog authorization page, click the "Authorize" button. | ||
3. The page will redirect back to OceanBase Cloud console. An notification will be displayed if successful , contact the technical support if error occurs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OAuth needs to be initialized in Datadog. Please update the steps to include each step a user takes to install the integration within Datadog. In order to handle site/region domains, the user will need to kick off authorization from Datadog. If a user kicks off authorization directly from your platform, this site parameter will not be sent, and the user will be prompted to select their site on the Datadog authorize page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please see above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please remove this image
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please see above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove this image
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please remove this image
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please see above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use the dashboard sent via email. Once the template is filled out, please update the json here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the dashboard using the template sent via email. There are fields missing in the dashboard that are in the template
Co-authored-by: emarsha94 <52013262+emarsha94@users.noreply.github.com>
@emarsha94 Hello, may I ask if there are any other content that need revised? Can it be approved now? |
update install guide
remove png
update dashboard with logo, description and so on
remove images
update email address
- Remove images - Update install steps - Update Dashboard with new template - Update email addresses
add images and update mainifest.json
What does this PR do?
Add a new integration for OceanBase Cloud.
Motivation
OceanBase Cloud provides fully managed database services with elastic scalability, ultra-fast performance, and high compatibility on global cloud infrastructure.
We Use the OceanBase Cloud Datadog integration to export metrics from OceanBase Cloud clusters to Datadog
This is an API based integration, which should only be installed in OceanBase Cloud environments.
What inspired you to submit this pull request?
Our users want to use datadog to monitor their OceanBase Cloud Clusters.
Review checklist
no-changelog
label attached