-
Notifications
You must be signed in to change notification settings - Fork 724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redis enterprise #2458
Redis enterprise #2458
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These metrics should be added to the metrics.py
and we should include as much of the metric output/examples in tests/data
to be used as fixtures to server to our tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Ideally we make changelog added additions minor fixes ( 1.1.0) but this is non-blocking. Approving 👍
…dd links where appropriate
What does this PR do?
Adds metrics groups to the test for validation
Motivation
Metrics are unavailable and so additional testing was performed
Review checklist
no-changelog
label attachedAdditional Notes
Metrics that are only available in certain environments/installations can not be asserted; they are considered ephemeral.