Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding a Baz tile #2461

Closed
wants to merge 15 commits into from
Closed

Adding a Baz tile #2461

wants to merge 15 commits into from

Conversation

nimrodkor
Copy link

@nimrodkor nimrodkor commented Aug 11, 2024 •
edited
Loading

What does this PR do?

This PR adds a tile for Baz

Review checklist

  • PR has a meaningful title or PR has the no-changelog label attached
  • Feature or bugfix has tests
  • Git history is clean
  • If PR impacts documentation, docs team has been notified or an issue has been opened on the documentation repo
  • If this PR includes a log pipeline, please add a description describing the remappers and processors.

@nimrodkor nimrodkor requested review from a team as code owners August 11, 2024 12:42
@cswatt cswatt added the editorial review Waiting on a more in-depth review from a docs team editor label Aug 12, 2024
@cswatt
Copy link
Contributor

cswatt commented Aug 12, 2024

Added DOCS-8694 to review.

maycmlee
maycmlee reviewed Aug 12, 2024
View reviewed changes
Copy link
Contributor

@maycmlee maycmlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some feedback!

baz/README.md Outdated Show resolved Hide resolved
baz/README.md Outdated Show resolved Hide resolved
baz/README.md Outdated Show resolved Hide resolved
baz/README.md Outdated Show resolved Hide resolved
baz/README.md Outdated Show resolved Hide resolved
baz/README.md Outdated Show resolved Hide resolved
baz/README.md Outdated Show resolved Hide resolved
baz/manifest.json Outdated Show resolved Hide resolved
baz/README.md Show resolved Hide resolved
nimrodkor and others added 2 commits August 13, 2024 09:53
@nimrodkor @maycmlee
Apply suggestions from code review
f6c14fb 
Co-authored-by: May Lee <may.lee@datadoghq.com>
@nimrodkor
Update assets obj
b23edc8
maycmlee
maycmlee approved these changes Aug 13, 2024
View reviewed changes
Copy link
Contributor

@maycmlee maycmlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving for docs, but there is an error in the manifest.json that needs to be fixed. Engineering should be able to provide more guidance on it.

@emarsha94
Copy link
Collaborator

Per Dominics email, closing the PR

@emarsha94 emarsha94 closed this Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maycmlee maycmlee maycmlee approved these changes

Assignees
No one assigned
Labels
docs/approved ecosystems/review-requested editorial review Waiting on a more in-depth review from a docs team editor kind/technology-partner product/HOLD product/review-requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nimrodkor @cswatt @emarsha94 @maycmlee