Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update oauth_clients.json with new redirect uri and permission list #2540

Merged
merged 3 commits into from
Nov 25, 2024

Conversation

droid-mohit
Copy link
Contributor

@droid-mohit droid-mohit commented Nov 20, 2024

What does this PR do?

This PR updates the oauth client for doctor droid integration

Motivation

What inspired you to submit this pull request?
This PR takes care of 2 things primarily:

  1. There is a change in the redirect uri domain for oauth installation.
  2. Adds apm_read to the set of permissions, as this will allow doctor droid to enrich monitor alerts with real time apm metric data and enable deeper insights for customers.

Review checklist

  • PR has a meaningful title or PR has the no-changelog label attached
  • Feature or bugfix has tests
  • Git history is clean
  • If PR impacts documentation, docs team has been notified or an issue has been opened on the documentation repo
  • If this PR includes a log pipeline, please add a description describing the remappers and processors.

Additional Notes

Anything else we should know when reviewing?

@droid-mohit droid-mohit requested a review from a team as a code owner November 20, 2024 20:51
Copy link
Contributor

@bgoldberg122 bgoldberg122 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but @droid-mohit please note that existing customers will have to re-authorize the integration to take advantage of the new scope. Please communicate that to them if necessary.

@droid-mohit
Copy link
Contributor Author

Hi @bgoldberg122 can you please merge this pull request?

@bgoldberg122 bgoldberg122 added this pull request to the merge queue Nov 25, 2024
Merged via the queue into DataDog:master with commit 2b69cea Nov 25, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants