[sdk] integrate with SDK testing/scaffolding facilities. #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
truthbk
force-pushed
the
jaime/sdk_gemfile
branch
from
19f8ea7
to
6162429
Compare
|
💎 |
[gem] fixing rakefile lint issue. [rakefile] env variable should be set on the calling (root) Rakefile. [rakefile] set the SDK_HOME environment variable too. [testing] adding pylintrc file to repo.
truthbk
force-pushed
the
jaime/sdk_gemfile
branch
from
7399940
to
8f68c0f
Compare
4 tasks
alopezz
pushed a commit
that referenced
this pull request
Sep 22, 2022
fix: compressed dashboard image
nmuesch
pushed a commit
that referenced
this pull request
Aug 7, 2023
mgarabed
pushed a commit
that referenced
this pull request
Aug 8, 2023
mgarabed
pushed a commit
that referenced
this pull request
Aug 9, 2023
* Adds cloudzero integration * updates app id to match app uuid from OAuth client (#1) * CP-13295 update datadog integration tile (#2) * Adds images * Updates manifest with images and suggested tag * Update readme to include marketing and setup language * formatting * CP-13295 Updates based on DD feedback (#3) * CP-13295 Updates based on further feedback (#4) * Updates based on copy feedback (#5) * CP-13295 Updates based on DD eng feedback (#6) * CP-13295 Copy changes requested by Datadog (#7) * Change from h3 to h2 (#9) * CP-13295 Update release date (#10)
james-eichelbaum
pushed a commit
that referenced
this pull request
Nov 3, 2023
* lint fixes * add sales email
james-eichelbaum
pushed a commit
that referenced
this pull request
Nov 13, 2023
* [ENT-2819] Robust Intelligence AI firewall integration initial commit (#1) * initial commit for check * check with correct metrics * add dashboard * update dashboard and readme * update dashboard title * fix readme links and add logos * fix support email link * update homepage and support email * [END-2821] Update README (#2) * update section on metrics collected * update firewall link and dashboard * [PINT-2462] readme fixes (#3) * readme fixes * update risk name * fix metrics section content * add image assets * [PINT-2485] PR build issues (#4) * lint fixes * add sales email * [PINT-2485] Address PR comments (#5) * update overview and description * add integrtaion version * add classifier tags * add dashboard description * add dashboard to manifest (#6) * [PINT-2541] readme review (#7) * add details to configure section * Add suggestion Co-authored-by: Arley Lewis <arley@robustintelligence.com> --------- Co-authored-by: Arley Lewis <arley@robustintelligence.com> * [PINT-2618] PR feedback and dashboard update (#8) * update readme and remove unnecessary file * upgrade dashboard * [PINT-2651] add dashboard banner image (#9) * add dashboard banner * update banner url * address PR comments (#10) * update description (#11) * [PINT-2719] readme and dashboard image (#12) * update dashboard image and description * update firewall image * update image ratio (#13) * [PINT-2891] add scope variable to dashboard (#14) * add scope variable * fix description * remove folder (#15) * fix import (#16) * run ddev validate ci * fix codecov * remove assets that are not required * add metrics check * add codeowners * fix format * remove non ascii character * fix test * add test --------- Co-authored-by: Arley Lewis <arley@robustintelligence.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR supersedes:
#3
It relies on the gemfile DataDog/datadog-sdk-testing#1 to provide the testing and scaffolding facilities which we hope will aid in streamlining the development process. Just like the original PR we address the following:
pre-commithooks.workflow
rake setup_envrake generate:skeleton[myintegration]rake lintrake ci:run[default]rake ci:run[myintegration]