Bump jnr-unixsocket to 0.27 #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olivielpeau
approved these changes
Feb 17, 2020
There was a problem hiding this comment.
There are meaningful tests of the UDS setup in https://github.com/DataDog/java-dogstatsd-client/blob/master/src/test/java/com/timgroup/statsd/UnixSocketTest.java, so it seems to be relatively safe to merge this.
Will leave a merge to @truthbk though
truthbk
approved these changes
Feb 18, 2020
There was a problem hiding this comment.
This looks fine, some Java7 tests were removed from the jnr-unixsocket repo CI, but not due to incompatibilities in the code itself, but because Travis dropped support and they introduced spotbug. To double-check I cloned the repo, removed the spotbugs check and ran the tests on a Java7 JVM successfully.
This looks 👌
truthbk
pushed a commit
that referenced
this pull request
Feb 25, 2020
dbyron0
pushed a commit
to locationlabs/java-dogstatsd-client
that referenced
this pull request
Jan 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Upgrades the jnr-unixsocket dependency to 0.27, so that it uses the new version of jffi (1.2.23) which passes the MacOS notarization test.