DD_SERVICE; DD_ENV; DD_VERSION; DD_TAGS env vars support #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpriima
requested review from
dougqh,
truthbk,
clamoriniere,
brettlangdon,
nmuesch and
andrewsouthard1
lpriima
force-pushed
the
lpriima/4-new-DD_env-vars
branch
from
fa27b7e to
38c5e55
Compare
lpriima
force-pushed
the
lpriima/4-new-DD_env-vars
branch
from
38c5e55 to
25435b0
Compare
truthbk
approved these changes
Apr 3, 2020
| env, | ||
| version, | ||
| tags; | ||
| private static final String PREFIX = "dd"; |
There was a problem hiding this comment.
Just wondering if this prefix is necessary. We mostly have service:foo for instance, not sure if it makes sense to introduce a different tag dd.service (for instance) for this. I'll let you discuss with your team. Obviously nothing's wrong with the implementation. Perhaps you did it because of the dd.internal.entitiy_id tag we were using which is prepended with dd?
There was a problem hiding this comment.
it's only for only these 4 tags. For other tags it might be different
dbyron0
pushed a commit
to locationlabs/java-dogstatsd-client
that referenced
this pull request
Jan 11, 2021
prior to DataDog#107 (released in version 2.10.0), they were public.
dbyron0
pushed a commit
to locationlabs/java-dogstatsd-client
that referenced
this pull request
Jan 11, 2021
prior to DataDog#107 (released in version 2.10.0), they were public.
dbyron0
pushed a commit
to locationlabs/java-dogstatsd-client
that referenced
this pull request
Jan 11, 2021
prior to DataDog#107 (released in version 2.10.0), they were public.
truthbk
pushed a commit
that referenced
this pull request
Jun 9, 2021
prior to #107 (released in version 2.10.0), they were public. Co-authored-by: David Byron <david.byron@avast.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.