fix: release StatsDSender executor #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
truthbk
reviewed
Jun 17, 2020
| @Override public Thread newThread(final Runnable runnable) { | ||
| final Thread result = delegate.newThread(runnable); | ||
| result.setName("StatsD-Sender-" + result.getName()); | ||
| result.setDaemon(true); |
There was a problem hiding this comment.
I'm kind of torn about making this a daemon thread or not. On one hand this is an IO intensive thread, and we might also want to make sure it shuts down in orderly fashion, on the other hand this runs next to the application and one could argue shouldn't really be a user thread....
There was a problem hiding this comment.
I don't have a strong option about it as well. But I thought it might be a good idea to make it a daemon since com.timgroup.statsd.NonBlockingStatsDClient is also creating daemon threads.
|
@truthbk Are you planning to do a new release some time soon?, thanks. |
|
@prudhvi early next week! |
dbyron0
pushed a commit
to locationlabs/java-dogstatsd-client
that referenced
this pull request
Jan 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes resource leak caused by ad47973. There is an executor in
StatsDSenderthat was never been shutdown.