[telemetry] dev-mode; additional metrics for better troubleshooting #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
truthbk
force-pushed
the
jaime/devmode
branch
from
0a4e1dd to
5b674cd
Compare
gh123man
reviewed
Jan 11, 2021
| private void sendMetric(final Message message) { | ||
| send(message); | ||
| this.telemetry.incrMetricsSent(1); | ||
| private boolean sendMetric(final Message message) { |
There was a problem hiding this comment.
Can this method be removed since now it's just a passthrough to send?
There was a problem hiding this comment.
I can check, in any case, I'd rather clean that up in a separate PR? Being a private method it's probably fine, but it might imply some refactoring. I can't remember off the top of my head why we kept it around.
gh123man
reviewed
Jan 11, 2021
| @@ -165,6 +316,18 @@ public void reset() { | |||
| this.packetsDropped.set(0); | |||
| this.packetsDroppedQueue.set(0); | |||
| this.aggregatedContexts.set(0); | |||
|
|
|||
| // if (devMode) { | |||
truthbk
force-pushed
the
jaime/devmode
branch
from
5b674cd to
c7f7476
Compare
gh123man
approved these changes
Jan 11, 2021
hush-hush
requested changes
Jan 12, 2021
hush-hush
approved these changes
Jan 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a dev-mode to the client telemetry that should better help debug metric submission, and more importantly metric aggregation. This is an initial catalog of dev-mode telemetry metrics, but more may be added in the future.