Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow clients to override metric sampling #162

Merged
merged 1 commit into from
Oct 13, 2021
Merged

Conversation

vickenty
Copy link
Contributor

@vickenty vickenty commented Oct 7, 2021

For example when submitting pre-sampled metrics to the client.

For example when submitting pre-sampled metrics to the client.
@vickenty vickenty requested a review from truthbk October 7, 2021 11:41
@vickenty vickenty merged commit 75df66a into master Oct 13, 2021
@vickenty vickenty deleted the vickenty/sampling branch October 13, 2021 14:26
@iksaif
Copy link
Contributor

iksaif commented Nov 16, 2021

👋 What is done in the unit test cannot be done in real life because super() and resolve() are package-private :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants