Fix visibility for overrideable methods #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
75df66a added option to override sampling behavior, but we need to expose methods used to build the client for it to be useful.
iksaif
approved these changes
Nov 26, 2021
truthbk
approved these changes
Dec 6, 2021
truthbk
approved these changes
Dec 6, 2021
vickenty
added a commit
that referenced
this pull request
Dec 14, 2021
75df66a added option to override sampling behavior, but we need to expose methods used to build the client for it to be useful.
vickenty
added a commit
that referenced
this pull request
Dec 14, 2021
75df66a added option to override sampling behavior, but we need to expose methods used to build the client for it to be useful.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
75df66a added option to override sampling behavior, but we need
to expose methods used to build the client for it to be useful.