Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Gradle 8.8 -> 8.12, bring in proper aarch64 native support #170

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

MattAlp
Copy link
Contributor

@MattAlp MattAlp commented Jan 14, 2025

What does this PR do?:
This bumps Gradle to include key support (gradle/gradle#30532, gradle/gradle#30120) for building on aarch64.

Motivation:
Native components such as gtest would only build when on an "arm64" system, while "aarch64" would make Gradle very confused (running clang with gcc arguments, etc.) and fail to build.

Additional Notes:
We should be mindful of deprecated features or plugin bumps that would be downstream of this change, as well as our CI and internal builders.

How to test the change?:
Verify that relevant building and testing works across our desired targets + your local dev setups.

For Datadog employees:

  • If this PR touches code that signs or publishes builds or packages, or handles
    credentials of any kind, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.
  • JIRA: PROF-11114

Unsure? Have a question? Request a review!

Copy link

🔧 Report generated by pr-comment-scanbuild

Scan-Build Report

User:runner@fv-az1915-631
Working Directory:/home/runner/work/java-profiler/java-profiler/ddprof-lib/src/test/make
Command Line:make -j4 clean all
Clang Version:Ubuntu clang version 18.1.3 (1ubuntu1)
Date:Tue Jan 14 17:41:33 2025

Bug Summary

Bug TypeQuantityDisplay?
All Bugs5
Logic error
Dereference of null pointer3
Suspicious operation
Bitwise shift1
Unused code
Dead nested assignment1

Reports

Bug Group Bug Type ▾ File Function/Method Line Path Length
Suspicious operationBitwise shiftvmStructs.cppfind87216
Unused codeDead nested assignmentvmStructs.cppcheckNativeBinding9771
Logic errorDereference of null pointersafeAccess.hload3318
Logic errorDereference of null pointersymbols_linux.hElfParser12928
Logic errorDereference of null pointerflightRecorder.cppflush15118

Copy link

🔧 Report generated by pr-comment-cppcheck

CppCheck Report

Warnings (7)

Style Violations (403)

@MattAlp
Copy link
Contributor Author

MattAlp commented Jan 14, 2025

I've tested this on our EC2 boxes + QEMU locally for a few architectures and operating systems.

@MattAlp MattAlp mentioned this pull request Jan 14, 2025
2 tasks
Copy link
Collaborator

@r1viollet r1viollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@r1viollet r1viollet merged commit cc078d9 into main Jan 15, 2025
45 checks passed
@github-actions github-actions bot added this to the 1.19.0 milestone Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants