-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Gradle 8.8 -> 8.12, bring in proper aarch64 native support #170
Merged
+93
−93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔧 Report generated by pr-comment-scanbuild Scan-Build Report
Bug Summary
Reports
|
I've tested this on our EC2 boxes + QEMU locally for a few architectures and operating systems. |
r1viollet
approved these changes
Jan 15, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?:
This bumps Gradle to include key support (gradle/gradle#30532, gradle/gradle#30120) for building on
aarch64
.Motivation:
Native components such as gtest would only build when on an "
arm64
" system, while "aarch64
" would make Gradle very confused (runningclang
withgcc
arguments, etc.) and fail to build.Additional Notes:
We should be mindful of deprecated features or plugin bumps that would be downstream of this change, as well as our CI and internal builders.
How to test the change?:
Verify that relevant building and testing works across our desired targets + your local dev setups.
For Datadog employees:
credentials of any kind, I've requested a review from
@DataDog/security-design-and-guidance
.Unsure? Have a question? Request a review!