-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Productize VMStructs-based stack walker #177
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddprof-test/src/test/java/com/datadoghq/profiler/AbstractProfilerTest.java
Show resolved
Hide resolved
ddprof-test/src/test/java/com/datadoghq/profiler/wallclock/BaseContextWallClockTest.java
Show resolved
Hide resolved
ddprof-test/src/test/java/com/datadoghq/profiler/wallclock/SmokeWallTest.java
Show resolved
Hide resolved
🔧 Report generated by pr-comment-scanbuild Scan-Build Report
Bug Summary
Reports
|
4f0af2d
to
8cbd20a
Compare
(cherry picked from commit ad5a03e6a7dbe994d1b2ba62050e5583f67eb43a)
8cbd20a
to
6a4710f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?:
A downport of async-profiler/async-profiler#1073
Motivation:
To get the full vmstructs capability - on-par with the upstream.
Additional Notes:
In addition to the upstream changes I increased the test coverage (and refactored the wall-clock tests to better support parametric tests).
There are still some rough edges for combination of Liberica JDK and aarch64 or anything in musl, where blocked threads will get many broken samples. This is still under investigation but it should not hold back this PR.
How to test the change?:
Just running the unit tests - the smoke tests were parameterized to exercise all available stackwalkers.
For Datadog employees:
credentials of any kind, I've requested a review from
@DataDog/security-design-and-guidance
.Unsure? Have a question? Request a review!