resolve todo

data-pipeline/src/trace_exporter.rs

@@ -9,12 +9,12 @@ use datadog_trace_utils::tracer_payload::TraceEncoding;
 use ddcommon::tag::Tag;
 use ddcommon::{connector, tag, Endpoint};
 use dogstatsd_client::{new_flusher, DogStatsDAction, Flusher};
+use either::Either;
 use hyper::http::uri::PathAndQuery;
 use hyper::{http, Body, Client, Method, Uri};
 use log::error;
 use std::{borrow::Borrow, collections::HashMap, str::FromStr};
 use tokio::runtime::Runtime;
-use either::Either;
 
 /// TraceExporterInputFormat represents the format of the input traces.
 /// The input format can be either Proxy or V0.4, where V0.4 is the default.

dogstatsd-client/src/lib.rs

@@ -22,8 +22,12 @@ use std::os::unix::net::UnixDatagram;
 const QUEUE_SIZE: usize = 32 * 1024;
 
 /// The `DogStatsDActionOwned` enum gathers the metric types that can be sent to the DogStatsD
-/// server. This type takes ownership of the relevant data to support the sidecar better
-/// TODO: writeup why combining these types is FRAUGHT
+/// server. This type takes ownership of the relevant data to support the sidecar better.
+///
+/// Originally I attempted to combine this type with `DogStatsDAction` but this GREATLY complicates
+/// the types to the point of insanity. I was unable to come up with a satisfactory approach that
+/// allows both the data-pipeline and sidecar crates to use the same type. If a future rustacean
+/// wants to take a stab and open a PR please do so!
 #[derive(Debug, Serialize, Deserialize)]
 pub enum DogStatsDActionOwned {
     Count(String, i64, Vec<Tag>),
@@ -36,8 +40,6 @@ pub enum DogStatsDActionOwned {
     Set(String, i64, Vec<Tag>),
 }
 
-// TODO: is there a way to make sure both of these stay in sync easily?
-
 /// The `DogStatsDAction` enum gathers the metric types that can be sent to the DogStatsD server.
 #[derive(Debug, Serialize, Deserialize)]
 pub enum DogStatsDAction<'a, T: AsRef<str>, V: IntoIterator<Item = &'a Tag>> {