Skip to content

Commit

Permalink
Add doc
Browse files Browse the repository at this point in the history
  • Loading branch information
VianneyRuhlmann committed Sep 19, 2024
1 parent 5d93e64 commit b01b838
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions data-pipeline/src/trace_exporter.rs
Original file line number Diff line number Diff line change
Expand Up @@ -299,9 +299,9 @@ impl TraceExporter {
}

/// Add all spans from the given iterator into the stats concentrator
/// # Panic
/// Will panic if another thread panicked will holding the lock on `stats_concentrator`
fn add_spans_to_stats<'a>(&self, spans: impl Iterator<Item = &'a pb::Span>) {
// TODO: How do we want to react if we have an error i.e. another thread panicked with
// the lock
if let StatsComputationStatus::StatsEnabled {
stats_concentrator,
cancellation_token: _,
Expand Down Expand Up @@ -415,6 +415,7 @@ pub struct TraceExporterBuilder {
client_computed_top_level: bool,

// Stats specific fields
/// A Some value enables stats-computation, None if it is disabled
stats_bucket_size: Option<time::Duration>,
peer_tags_aggregation: bool,
compute_stats_by_span_kind: bool,
Expand Down

0 comments on commit b01b838

Please sign in to comment.